From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: git@vger•kernel.org,
Johannes Schindelin <johannes.schindelin@gmx•de>,
kasal@ucw•cz, sandals@crustytoothpaste•net
Subject: Re: [PATCH/RFC] blame: CRLF in the working tree and LF in the repo
Date: Sun, 26 Apr 2015 22:31:11 -0700 [thread overview]
Message-ID: <xmqqzj5uxhls.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <553CD3DA.9090700@web.de> ("Torsten Bögershausen"'s message of "Sun, 26 Apr 2015 14:02:34 +0200")
Torsten Bögershausen <tboegi@web•de> writes:
> Although the intention of 4d4813a5 is good, it breaks
> the usual EOL-handling for Windows.
> Until we have a better solution, we suggest to revert it.
That makes it sound like you are proposing to rob Peter to pay Paul,
but that is not how we do things around here. If both the case
4d4813a5 tried to solve and the issue reported by Stepan need to be
satisfied, the current code will stay as-is until you can find a
good solution to make both happy.
Having said that.
I suspect (I haven't looked very carefully for this round yet to be
sure, though) that it may turn out that the commit you are proposing
to revert was a misguided attempt to "fix" a non issue, or to break
the behaviour to match a mistaken expectation. If that is the case
then definitely the reversion is a good idea, and you should argue
along that line of justification.
We'd just be fixing an old misguided and bad change in such a case.
Thanks.
next prev parent reply other threads:[~2015-04-27 5:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-26 12:02 [PATCH/RFC] blame: CRLF in the working tree and LF in the repo Torsten Bögershausen
2015-04-26 18:36 ` Eric Sunshine
2015-04-27 4:39 ` Stepan Kasal
2015-04-27 5:31 ` Junio C Hamano [this message]
2015-04-27 6:11 ` Stepan Kasal
2015-04-27 18:58 ` Johannes Sixt
2015-04-27 19:45 ` Torsten Bögershausen
2015-04-28 18:42 ` Johannes Sixt
2015-04-28 19:52 ` Junio C Hamano
2015-04-28 20:19 ` Johannes Sixt
2015-04-28 21:58 ` Stepan Kasal
2015-04-27 17:47 ` Junio C Hamano
2015-04-27 19:40 ` Torsten Bögershausen
2015-04-28 7:28 ` Junio C Hamano
2015-04-28 7:40 ` Torsten Bögershausen
2015-04-28 1:17 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzj5uxhls.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=kasal@ucw$(echo .)cz \
--cc=sandals@crustytoothpaste$(echo .)net \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox