From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Matt Whiteley <mattwhiteley@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH 1/2] clone: add disassociate alias to dissociate option
Date: Fri, 20 Feb 2015 23:13:47 -0800 [thread overview]
Message-ID: <xmqqzj87wxck.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150221062754.GC29665@peff.net> (Jeff King's message of "Sat, 21 Feb 2015 01:27:55 -0500")
Jeff King <peff@peff•net> writes:
> On Fri, Feb 20, 2015 at 11:10:22AM -0800, Matt Whiteley wrote:
>
>> diff --git a/builtin/clone.c b/builtin/clone.c
>> index 316c75d..7e193ae 100644
>> --- a/builtin/clone.c
>> +++ b/builtin/clone.c
>> @@ -97,6 +97,8 @@ static struct option builtin_clone_options[] = {
>> N_("clone only one branch, HEAD or --branch")),
>> OPT_BOOL(0, "dissociate", &option_dissociate,
>> N_("use --reference only while cloning")),
>> + OPT_BOOL(0, "disassociate", &option_dissociate,
>> + N_("use --reference only while cloning")),
>
> Should this second one be marked as OPT_HIDDEN? I do not think we need
> to show both in "git clone --help".
For that matter, I am not sure why we want to add this synonym in
the first place.
http://www.merriam-webster.com/dictionary/dissociate
: to end your relationship with or connection to someone or
something : to separate (yourself) from someone or something
which is exactly what I wanted the option to achieve.
next prev parent reply other threads:[~2015-02-21 7:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 19:10 [PATCH] --disassociate alias for --dissociate clone option Matt Whiteley
2015-02-20 19:10 ` [PATCH 1/2] clone: add disassociate alias to dissociate option Matt Whiteley
2015-02-21 6:27 ` Jeff King
2015-02-21 7:13 ` Junio C Hamano [this message]
2015-02-21 7:35 ` Jeff King
2015-02-22 18:32 ` Junio C Hamano
2015-02-24 9:06 ` Michael Haggerty
2015-02-24 20:06 ` Junio C Hamano
2015-02-24 22:00 ` Michael Haggerty
2015-02-20 19:10 ` [PATCH 2/2] clone: Realign lines near disassociate option Matt Whiteley
2015-02-20 22:01 ` [PATCH] --disassociate alias for --dissociate clone option Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzj87wxck.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mattwhiteley@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox