Subject: Re: [PATCH v2] format-patch --signature-file <file>

From: Junio C Hamano <[email-masked]>
Date: Tue, 20 May 2014 08:06:50 -0700

Jeff King <[email-masked]> writes:

> You could do:
>
>   #define DEFAULT_SIGNATURE git_version_string
>   static const char *signature = DEFAULT_SIGNATURE;
>
>   ...
>
>   if (signature == DEFAULT_SIGNATURE)
>      ...
>
> but maybe that is getting a little unwieldy, considering the scope of
> the original problem.

I agree.  It is an invitation for doing something like

	#define DEFAULT_SIGNATURE "-- \nfoo bar\n"

which defeats the purpose.

I have an unrelated and larger design level suggestion, but it may
be better for me to refrain from sending it during the -rc freeze.