Subject: Re: [PATCH] rev-parse: fix --resolve-git-dir argument handling

From: Junio C Hamano <[email-masked]>
Date: Tue, 18 Feb 2014 16:25:37 -0800

Junio C Hamano <[email-masked]> writes:

> John Keeping <[email-masked]> writes:
>
>> There are two problems here:
>>
>> 1) If no argument is provided, then the command segfaults
>> 2) The argument is not consumed, so there will be excess output
>>
>> Fix both of these in one go by restructuring the handler for this
>> option.
>>
>> Reported-by: Daniel Hahler <[email-masked]>
>> Signed-off-by: John Keeping <[email-masked]>
>> ---
>
> Looks sensible; thanks.

Ehh, I spoke too fast. Don't we already have this queued as a43219f2
(rev-parse: check i before using argv[i] against argc, 2014-01-28)?