From: Junio C Hamano <gitster@pobox•com>
To: Thomas Rast <tr@thomasrast•ch>
Cc: git@vger•kernel.org, Jonathan Nieder <jrnieder@gmail•com>,
Paul Mackerras <paulus@samba•org>,
Jens Lehmann <Jens.Lehmann@web•de>,
Thomas Rast <trast@inf•ethz.ch>
Subject: Re: [PATCH v2 1/7] gitk: support -G option from the command line
Date: Tue, 29 Oct 2013 17:52:49 -0700 [thread overview]
Message-ID: <xmqqzjprd1ge.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <72ba9e0cd862a2fb014d0633802f9afbb0bea27d.1383031141.git.tr@thomasrast.ch> (Thomas Rast's message of "Tue, 29 Oct 2013 08:20:34 +0100")
Thomas Rast <tr@thomasrast•ch> writes:
> From: Thomas Rast <trast@inf•ethz.ch>
>
> The -G option's usage is exactly analogous to that of -S, so
> supporting it is easy.
>
> Signed-off-by: Thomas Rast <trast@inf•ethz.ch>
> ---
> gitk-git/gitk | 2 +-
You CC'ed Paul, which is absolutely the right thing to do, but
please make patches against his tree, which does not have gitk-git/
directory at the top-level.
I think the patch itself makes sense.
Thanks.
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 5cd00d8..0e95814 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -227,7 +227,7 @@ proc parseviewargs {n arglist} {
> "--until=*" - "--before=*" - "--max-age=*" - "--min-age=*" -
> "--author=*" - "--committer=*" - "--grep=*" - "-[iE]" -
> "--remove-empty" - "--first-parent" - "--cherry-pick" -
> - "-S*" - "--pickaxe-all" - "--pickaxe-regex" -
> + "-S*" - "-G*" - "--pickaxe-all" - "--pickaxe-regex" -
> "--simplify-by-decoration" {
> # These mean that we get a subset of the commits
> set filtered 1
next prev parent reply other threads:[~2013-10-30 0:53 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 19:44 [PATCH gitk 0/4] gitk support for git log -L Thomas Rast
2013-06-09 19:44 ` [PATCH gitk 1/4] gitk: refactor per-line part of getblobdiffline and its support Thomas Rast
2013-06-09 19:44 ` [PATCH gitk 2/4] gitk: split out diff part in $commitinfo Thomas Rast
2013-06-09 19:44 ` [PATCH gitk 3/4] gitk: support showing the gathered inline diffs Thomas Rast
2013-06-09 19:44 ` [PATCH gitk 4/4] gitk: recognize -L option Thomas Rast
2013-07-23 15:19 ` [PATCH gitk 0/4] gitk support for git log -L Thomas Rast
2013-07-29 19:37 ` Thomas Rast
2013-07-29 20:07 ` Jens Lehmann
2013-07-31 13:17 ` Thomas Rast
2013-08-18 11:54 ` Paul Mackerras
2013-08-19 8:21 ` Thomas Rast
2013-08-19 17:30 ` Junio C Hamano
2013-10-13 6:31 ` Thomas Rast
2013-10-14 5:25 ` Jonathan Nieder
2013-10-20 16:57 ` [PATCH] Documentation: revamp gitk(1) Thomas Rast
2013-10-29 7:20 ` [PATCH v2 0/7] gitk -L Thomas Rast
2013-10-29 7:20 ` [PATCH v2 1/7] gitk: support -G option from the command line Thomas Rast
2013-10-30 0:52 ` Junio C Hamano [this message]
2013-10-30 6:30 ` Thomas Rast
2013-10-30 16:42 ` Junio C Hamano
2013-10-29 7:20 ` [PATCH v2 2/7] gitk: refactor per-line part of getblobdiffline and its support Thomas Rast
2013-10-29 7:20 ` [PATCH v2 3/7] gitk: split out diff part in $commitinfo Thomas Rast
2013-10-29 7:20 ` [PATCH v2 4/7] gitk: support showing the gathered inline diffs Thomas Rast
2013-10-29 7:20 ` [PATCH v2 5/7] gitk: recognize -L option Thomas Rast
2013-10-29 7:20 ` [PATCH v2 6/7] Documentation: put blame/log -L in sticked form Thomas Rast
2013-10-30 1:11 ` Junio C Hamano
2013-10-30 6:29 ` Thomas Rast
2013-10-30 17:09 ` Junio C Hamano
2013-10-30 18:59 ` Thomas Rast
2013-10-30 19:37 ` Junio C Hamano
2013-11-16 17:37 ` [PATCH v3 gitk 0/5] gitk -L Thomas Rast
2013-11-16 17:37 ` [PATCH v3 gitk 1/5] gitk: support -G option from the command line Thomas Rast
2013-11-16 17:37 ` [PATCH v3 gitk 2/5] gitk: refactor per-line part of getblobdiffline and its support Thomas Rast
2013-11-16 17:37 ` [PATCH v3 gitk 3/5] gitk: split out diff part in $commitinfo Thomas Rast
2013-11-16 17:37 ` [PATCH v3 gitk 4/5] gitk: support showing the gathered inline diffs Thomas Rast
2013-11-16 17:37 ` [PATCH v3 gitk 5/5] gitk: recognize -L option Thomas Rast
2013-12-01 22:25 ` [PATCH v3 gitk 0/5] gitk -L Paul Mackerras
2013-11-16 17:37 ` [PATCH v3 0/3] Documentation: stuck arguments and gitk log -L Thomas Rast
2013-11-16 17:37 ` [PATCH v3 1/3] commit-tree: use prefixcmp instead of memcmp(..., N) Thomas Rast
2013-11-16 17:37 ` [PATCH v3 2/3] Documentation: convert to --option=arg form where possible Thomas Rast
2013-11-16 17:37 ` [PATCH v3 3/3] Documentation/gitk: document -L option Thomas Rast
2013-10-29 7:20 ` [PATCH v2 7/7] " Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzjprd1ge.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Jens.Lehmann@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=tr@thomasrast$(echo .)ch \
--cc=trast@inf$(echo .)ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox