From: "Hyunki Koo" <hyunki00.koo@samsung•com>
To: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation•org>
Cc: linux-samsung-soc@vger•kernel.org, linux-kernel@vger•kernel.org,
'Krzysztof Kozlowski' <krzk@kernel•org>,
'Kukjin Kim' <kgene@kernel•org>,
linux-serial@vger•kernel.org, 'Jiri Slaby' <jslaby@suse•com>,
linux-arm-kernel@lists•infradead.org
Subject: RE: [PATCH v8 1/3] serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg
Date: Wed, 6 May 2020 08:30:46 +0900 [thread overview]
Message-ID: <000001d62335$33d03410$9b709c30$@samsung.com> (raw)
In-Reply-To: <20200505142325.GA816056@kroah.com>
On Tuesday, May 5, 2020 at 2020 11:23:00 PM +0900, Greg Kroah-Hartman wrote:
> On Mon, Apr 20, 2020 at 10:32:56AM +0900, Hyunki Koo wrote:
> > This patch change the name of macro for general usage.
> >
> > Signed-off-by: Hyunki Koo <hyunki00.koo@samsung•com>
>
> This patch series creates the following build error, which is not
> allowed:
>
> CC [M] drivers/tty/serial/samsung_tty.o
> drivers/tty/serial/samsung_tty.c:186:13: warning: ‘wr_reg_barrier’
> defined but not used [-Wunused-function]
> 186 | static void wr_reg_barrier(struct uart_port *port, u32 reg, u32 val)
> | ^~~~~~~~~~~~~~
>
> Please fix up and resend. Always make sure you keep the reviewed-by
> tags from others as well.
>
> greg k-h
I tested on latest kernel today one more time, there is no error and warning on my side, not only patch 1/3 and patch 3/3
Line 1735: CC drivers/tty/serial/samsung_tty.o
Line 343: CC drivers/tty/serial/samsung_tty.o
wr_reg_barrier is not defined in patch 1/3,
and wr_reg_barrier is define and used in patch3/3
it might be no warning.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-05 23:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200420013322epcas2p263e72997dd4ebdaf00b095a83a6b6651@epcas2p2.samsung.com>
2020-04-20 1:32 ` [PATCH v8 1/3] serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg Hyunki Koo
2020-04-20 1:32 ` [PATCH v8 3/3] tty: samsung_tty: 32-bit access for TX/RX hold registers Hyunki Koo
2020-04-20 14:19 ` Hyunki Koo
2020-05-05 14:23 ` [PATCH v8 1/3] serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg Greg Kroah-Hartman
2020-05-05 23:30 ` Hyunki Koo [this message]
2020-05-06 6:31 ` 'Greg Kroah-Hartman'
2020-05-06 7:18 ` Hyunki Koo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d62335$33d03410$9b709c30$@samsung.com' \
--to=hyunki00.koo@samsung$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jslaby@suse$(echo .)com \
--cc=kgene@kernel$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-serial@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox