From: jhbird.choi@samsung•com (Jonghwan Choi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] thermal: Add missing cpumask_clear
Date: Sat, 05 Jul 2014 09:40:38 +0900 [thread overview]
Message-ID: <000801cf97e9$bde80f70$39b82e50$@samsung.com> (raw)
In-Reply-To: <53B747FF.5010604@gmail.com>
On Fri, Jul 5, 2014 at 9:34 AM, Tomasz Figa <tomasz.figa@gmail•com> wrote:
> > Console message-> 4.861157] [c6] --ID [ 1] = 0,4-5,7 (4,5,7 cpu bit
> > was set.)
> >
> > And when I tried to register two cooling devices with cpumask_set_cpu(0, &mask_val) and
> cpumask_set_cpu(4, &mask_val).
> >
> > I found that cpu 0 bit is also set in latter cpumask. (I hope latter
> > cpumask has a cpu 4 bit.)
> >
> > So I think that cpumask_clear should be inserted.
>
> I believe Sachin's concern was related to your patch description. A good description should say what
> the patch changes and what is the rationale behind this change. Also for fixes it is a good practice
> to specify observed issues in patch description as well.
>
> Best regards,
-> You are right.
Thanks for your kind advice.
Best regards.
next prev parent reply other threads:[~2014-07-05 0:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 10:22 [PATCH] thermal: Add missing cpumask_clear Jonghwan Choi
2014-07-04 11:23 ` Sachin Kamat
2014-07-04 23:37 ` Jonghwan Choi
2014-07-05 0:34 ` Tomasz Figa
2014-07-05 0:40 ` Jonghwan Choi [this message]
2014-07-05 14:59 ` Sachin Kamat
2014-07-08 13:56 ` Javi Merino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000801cf97e9$bde80f70$39b82e50$@samsung.com' \
--to=jhbird.choi@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox