From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 7/10] ARM: S5PV210: Fix wrong EPLL rate getting on setup clocks
Date: Fri, 08 Oct 2010 19:37:00 +0900 [thread overview]
Message-ID: <001e01cb66d4$c178a400$4469ec00$%kim@samsung.com> (raw)
In-Reply-To: <1286193919-19830-1-git-send-email-sw.youn@samsung.com>
Seungwhan Youn wrote:
>
> This patch fix wrong EPLL getting on setup clocks on S5PV210.
>
> Signed-off-by: Seungwhan Youn <sw.youn@samsung•com>
> ---
> arch/arm/mach-s5pv210/clock.c | 3 ++-
> arch/arm/mach-s5pv210/include/mach/regs-clock.h | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock.c
> index 3f3b7ba..bcbe7e9 100644
> --- a/arch/arm/mach-s5pv210/clock.c
> +++ b/arch/arm/mach-s5pv210/clock.c
> @@ -1040,7 +1040,8 @@ void __init_or_cpufreq s5pv210_setup_clocks(void)
>
> apll = s5p_get_pll45xx(xtal, __raw_readl(S5P_APLL_CON), pll_4508);
> mpll = s5p_get_pll45xx(xtal, __raw_readl(S5P_MPLL_CON), pll_4502);
> - epll = s5p_get_pll45xx(xtal, __raw_readl(S5P_EPLL_CON), pll_4500);
> + epll = s5p_get_pll90xx(xtal, __raw_readl(S5P_EPLL_CON0),
> + __raw_readl(S5P_EPLL_CON1));
Maybe you wanted to implement fractional PLL 4600B...not used 90xx in there.
So need to update plat/pll.h to epll of s5pv210.
> vpllsrc = clk_get_rate(&clk_vpllsrc.clk);
> vpll = s5p_get_pll45xx(vpllsrc, __raw_readl(S5P_VPLL_CON),
pll_4502);
>
> diff --git a/arch/arm/mach-s5pv210/include/mach/regs-clock.h
b/arch/arm/mach-
> s5pv210/include/mach/regs-clock.h
> index 499aef7..5968535 100644
> --- a/arch/arm/mach-s5pv210/include/mach/regs-clock.h
> +++ b/arch/arm/mach-s5pv210/include/mach/regs-clock.h
> @@ -24,7 +24,8 @@
>
> #define S5P_APLL_CON S5P_CLKREG(0x100)
> #define S5P_MPLL_CON S5P_CLKREG(0x108)
> -#define S5P_EPLL_CON S5P_CLKREG(0x110)
> +#define S5P_EPLL_CON0 S5P_CLKREG(0x110)
> +#define S5P_EPLL_CON1 S5P_CLKREG(0x114)
> #define S5P_VPLL_CON S5P_CLKREG(0x120)
>
> #define S5P_CLK_SRC0 S5P_CLKREG(0x200)
> --
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung•com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2010-10-08 10:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 11:25 [PATCH 0/10] Add S/PDIF common driver for Samsung SoCs Seungwhan Youn
2010-10-04 11:31 ` [PATCH 1/10] ARM: S5PC100: Add S/PDIF platform device Seungwhan Youn
2010-10-04 18:23 ` Mark Brown
2010-10-08 9:54 ` Kukjin Kim
2010-10-04 11:39 ` [PATCH 2/10] ARM: S5PC100: Modify SCLK_AUDIO{0,1,2} clock as sysclks Seungwhan Youn
2010-10-04 18:28 ` Mark Brown
2010-10-08 9:57 ` Kukjin Kim
2010-10-04 11:42 ` [PATCH 3/10] ARM: S5PC100: Add SCLK_SPDIF clock Seungwhan Youn
2010-10-04 18:30 ` Mark Brown
2010-10-05 0:29 ` [alsa-devel] " Jassi Brar
2010-10-08 10:11 ` Kukjin Kim
2010-10-08 10:45 ` Seungwhan Youn
2010-10-08 10:51 ` Kukjin Kim
2010-10-04 11:46 ` [PATCH 4/10] ARM: S5PV210: Add S/PDIF platform device Seungwhan Youn
2010-10-04 18:38 ` Mark Brown
2010-10-08 10:14 ` Kukjin Kim
2010-10-04 11:52 ` [PATCH 5/10] ARM: S5PV210: Add SCLK_SPDIF clock Seungwhan Youn
2010-10-04 18:39 ` Mark Brown
2010-10-05 0:30 ` [alsa-devel] " Jassi Brar
2010-10-08 10:16 ` Kukjin Kim
2010-10-08 10:51 ` Seungwhan Youn
2010-10-04 11:57 ` [PATCH 6/10] ARM: S5PV210: Add audio clocks as sysclk Seungwhan Youn
2010-10-04 18:42 ` Mark Brown
2010-10-08 10:18 ` Kukjin Kim
2010-10-04 12:05 ` [PATCH 7/10] ARM: S5PV210: Fix wrong EPLL rate getting on setup clocks Seungwhan Youn
2010-10-08 10:37 ` Kukjin Kim [this message]
2010-10-08 10:55 ` Seungwhan Youn
2010-10-04 12:07 ` [PATCH 8/10] ARM: S5PV210: Add EPLL clock operations Seungwhan Youn
2010-10-08 10:29 ` Kukjin Kim
2010-10-08 10:53 ` Seungwhan Youn
2010-10-04 12:13 ` [PATCH 9/10] ASoC: SAMSUNG: Add S/PDIF CPU driver Seungwhan Youn
2010-10-04 22:02 ` Mark Brown
2010-10-05 2:08 ` Seungwhan Youn
2010-10-04 12:16 ` [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio Seungwhan Youn
2010-10-04 22:42 ` Mark Brown
2010-10-05 1:10 ` [alsa-devel] " Jassi Brar
2010-10-05 2:19 ` Jassi Brar
2010-10-05 4:43 ` Mark Brown
2010-10-05 5:39 ` Jassi Brar
2010-10-05 5:59 ` Mark Brown
2010-10-05 7:09 ` Jassi Brar
2010-10-05 7:39 ` Seungwhan Youn
2010-10-06 6:34 ` Kukjin Kim
2010-10-07 1:33 ` Seungwhan Youn
2010-10-08 9:07 ` Seungwhan Youn
2010-10-08 9:48 ` Kukjin Kim
2010-10-09 1:52 ` Jassi Brar
2010-10-11 10:47 ` Mark Brown
2010-10-12 1:27 ` Jassi Brar
2010-10-12 3:25 ` Seungwhan Youn
2010-10-05 16:54 ` Mark Brown
2010-10-04 13:35 ` [alsa-devel] [PATCH 0/10] Add S/PDIF common driver for Samsung SoCs Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001e01cb66d4$c178a400$4469ec00$%kim@samsung.com' \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox