From: jg1.han@samsung•com (Jingoo Han)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos
Date: Wed, 19 Jun 2013 10:13:16 +0900 [thread overview]
Message-ID: <002401ce6c8a$2dd1e4a0$8975ade0$@samsung.com> (raw)
In-Reply-To: <201306181556.47656.arnd@arndb.de>
On Tuesday, June 18, 2013 10:57 PM, Arnd Bergmann wrote:
> On Tuesday 18 June 2013, Jingoo Han wrote:
> > On Monday, June 17, 2013 9:45 PM, Arnd Bergmann wrote:
> > > On Monday 17 June 2013 18:45:52 Jingoo Han wrote:
> > > > On Friday, June 14, 2013 9:54 PM, Arnd Bergmann wrote:
> > > > >
[.....]
> >
> > I will remove a 'remove' callback. Is it OK?
> > Or what should I do?
>
> I think you should keep the remove function, but add a comment explaining that
> you don't allow module unload and that in order to allow it, the remove function
> will have to remove all pci buses and devices under the host bridge.
Then, do you mean the following?
static int __exit exynos_pcie_remove(struct platform_device *pdev)
{
struct pcie_port *pp = platform_get_drvdata(pdev);
clk_disable_unprepare(pp->bus_clk);
clk_disable_unprepare(pp->clk);
return 0;
}
static struct platform_driver exynos_pcie_driver = {
.remove = __exit_p(exynos_pcie_remove),
[.....]
/* Exynos PCIe driver does not allow module unload */
static int __init pcie_init(void)
{
hook_fault_code(16 + 6, exynos_pcie_abort, SIGBUS, 0,
"imprecise external abort");
platform_driver_probe(&exynos_pcie_driver, exynos_pcie_probe);
return 0;
}
subsys_initcall(pcie_init);
MODULE_AUTHOR("Jingoo Han <jg1.han@samsung•com>");
MODULE_DESCRIPTION("Samsung PCIe host controller driver");
MODULE_LICENSE("GPLv2");
>
> Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-06-19 1:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 13:22 [PATCH V5 1/3] pci: Add PCIe driver for Samsung Exynos Jingoo Han
2013-06-13 14:13 ` Arnd Bergmann
2013-06-14 8:18 ` Jingoo Han
2013-06-14 10:53 ` Thierry Reding
2013-06-14 12:38 ` Arnd Bergmann
2013-07-17 5:07 ` Thierry Reding
2013-06-14 12:53 ` Arnd Bergmann
2013-06-17 9:45 ` Jingoo Han
2013-06-17 12:44 ` Arnd Bergmann
2013-06-18 3:52 ` Jingoo Han
2013-06-18 13:56 ` Arnd Bergmann
2013-06-19 1:13 ` Jingoo Han [this message]
2013-06-19 12:43 ` Arnd Bergmann
2013-06-20 6:41 ` Jingoo Han
2013-06-18 5:35 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002401ce6c8a$2dd1e4a0$8975ade0$@samsung.com' \
--to=jg1.han@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox