From: sangsu4u.park@samsung•com (Sangsu Park)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock
Date: Wed, 16 Jan 2013 10:08:06 +0900 [thread overview]
Message-ID: <00fb01cdf385$f116dde0$d34499a0$@samsung.com> (raw)
In-Reply-To: <50F4CDA5.3090904@linaro.org>
On 1/15/2013 12:32 PM, Tushar Behera wrote:
> On 09/28/2012 04:09 PM, Sangsu Park wrote:
> > Remove I2S0 clock from peril since peril doesn't have I2S0 clock for
EXYNOS4.
> > Audio Subsystem block has I2S0 clk.
> >
> > Signed-off-by: sangsu <sangsu@sangsu-P560.(none)>
> > ---
> > arch/arm/mach-exynos/clock-exynos4.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/clock-exynos4.c
> > b/arch/arm/mach-exynos/clock-exynos4.c
> > index 6a45c9a..fa8a134 100644
> > --- a/arch/arm/mach-exynos/clock-exynos4.c
> > +++ b/arch/arm/mach-exynos/clock-exynos4.c
> > @@ -613,11 +613,6 @@ static struct clk exynos4_init_clocks_off[] = {
> > .ctrlbit = (1 << 18),
> > }, {
> > .name = "iis",
> > - .devname = "samsung-i2s.0",
> > - .enable = exynos4_clk_ip_peril_ctrl,
> > - .ctrlbit = (1 << 19),
> > - }, {
> > - .name = "iis",
> > .devname = "samsung-i2s.1",
> > .enable = exynos4_clk_ip_peril_ctrl,
> > .ctrlbit = (1 << 20),
> >
>
> After this clock has been removed, I2S0 registration fails on EXYNOS4
> based boards (clk_get for iis clock fails). The alternate clock from
> Audio subsystem block is missing.
>
Yes, you're right.
I2S0 clock doesn't belong to peril clock.
Audio Subsystem has its own clock and also I2S0 clock.
That work might be missed. I'll do that work soon.
Thanks.
> --
> Tushar Behera
next prev parent reply other threads:[~2013-01-16 1:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 10:39 [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock Sangsu Park
2013-01-15 3:31 ` Tushar Behera
2013-01-16 1:08 ` Sangsu Park [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-05 7:37 Sangsu Park
2012-10-08 2:15 ` Sangbeom Kim
2012-10-23 10:30 ` Kukjin Kim
2012-10-08 1:31 Sangsu Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00fb01cdf385$f116dde0$d34499a0$@samsung.com' \
--to=sangsu4u.park@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox