From: p.fedin@samsung•com (Pavel Fedin)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 7/7] KVM: arm: implement kvm_set_msi by gsi direct mapping
Date: Thu, 02 Jul 2015 18:37:55 +0300 [thread overview]
Message-ID: <02ea01d0b4dd$1186e690$3494b3b0$@samsung.com> (raw)
In-Reply-To: <55955290.1030009@linaro.org>
Hello!
> > Given API change i suggest (using KVM_MSI_VALID_DEVID flag), we could get rid of all these
if()'s
> > here. Just forward all parameters to vGIC implementation code and let it do its checks.
> I don't understand this comment. Here this is the kernel struct that is
> used (struct kvm_kernel_irq_routing_entry) and not the user one
> (kvm_irq_routing_entry). The kernel struct does not have the flag field.
Easy. ARM code can always use struct kvm_extended_msi, and flags can go to this structure.
> Another reason I think to keep using the type for homogeneity.
Homogeneity is perfect IMHO.
If that would be simpler for you, i could post a patch for this which i made on top of your series.
Sorry, i don't have time to respin the whole thing, busy with qemu GICv3 fight :)
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-07-02 15:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 15:37 [PATCH 0/7] KVM: arm/arm64: gsi routing support Eric Auger
2015-06-29 15:37 ` [PATCH 1/7] KVM: api: add kvm_irq_routing_extended_msi Eric Auger
2015-07-02 7:26 ` Pavel Fedin
2015-07-02 8:41 ` Pavel Fedin
2015-07-02 14:50 ` Eric Auger
2015-07-02 14:49 ` Eric Auger
2015-07-02 15:14 ` Andre Przywara
2015-07-02 15:22 ` Eric Auger
2015-07-02 15:39 ` Pavel Fedin
2015-07-02 15:41 ` Eric Auger
2015-07-03 15:29 ` Pavel Fedin
2015-07-03 15:42 ` Eric Auger
2015-07-03 9:05 ` Andre Przywara
2015-07-03 15:53 ` Andre Przywara
2015-07-06 6:42 ` Pavel Fedin
2015-07-06 8:30 ` Andre Przywara
2015-07-06 9:30 ` Christoffer Dall
2015-07-06 10:05 ` Andre Przywara
2015-07-06 10:37 ` Christoffer Dall
2015-07-06 11:07 ` Paolo Bonzini
2015-07-06 11:23 ` Andre Przywara
2015-07-06 11:51 ` Paolo Bonzini
2015-07-06 13:32 ` Pavel Fedin
2015-07-06 15:01 ` Eric Auger
2015-07-06 15:52 ` Andre Przywara
2015-07-06 17:02 ` Eric Auger
2015-07-07 7:23 ` Pavel Fedin
2015-07-07 7:43 ` Eric Auger
2015-07-06 15:37 ` Andre Przywara
2015-07-06 15:54 ` Paolo Bonzini
2015-07-06 16:08 ` Andre Przywara
2015-07-07 7:16 ` Pavel Fedin
2015-07-07 10:02 ` Andre Przywara
2015-07-07 10:57 ` Pavel Fedin
2015-07-06 12:08 ` Christoffer Dall
2015-07-06 13:33 ` Pavel Fedin
2015-07-06 15:09 ` Andre Przywara
2015-06-29 15:37 ` [PATCH 2/7] KVM: kvm_host: add kvm_extended_msi Eric Auger
2015-07-02 17:03 ` Andre Przywara
2015-06-29 15:37 ` [PATCH 3/7] KVM: irqchip: convey devid to kvm_set_msi Eric Auger
2015-06-29 15:37 ` [PATCH 4/7] KVM: arm/arm64: enable irqchip routing Eric Auger
2015-06-30 13:39 ` Andre Przywara
2015-06-30 14:02 ` Eric Auger
2015-06-29 15:37 ` [PATCH 5/7] KVM: arm/arm64: build a default routing table Eric Auger
2015-06-29 15:37 ` [PATCH 6/7] KVM: arm/arm64: enable MSI routing Eric Auger
2015-06-29 15:37 ` [PATCH 7/7] KVM: arm: implement kvm_set_msi by gsi direct mapping Eric Auger
2015-07-02 7:53 ` Pavel Fedin
2015-07-02 15:02 ` Eric Auger
2015-07-02 15:37 ` Pavel Fedin [this message]
2015-07-02 17:10 ` Andre Przywara
2015-07-03 5:34 ` Eric Auger
2015-07-05 19:40 ` [PATCH 0/7] KVM: arm/arm64: gsi routing support Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02ea01d0b4dd$1186e690$3494b3b0$@samsung.com' \
--to=p.fedin@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox