From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: DTS: correct the capability string for mmc0
Date: Wed, 25 Jun 2014 20:19:54 +0900 [thread overview]
Message-ID: <030a01cf9067$63f3ff80$2bdbfe80$@samsung.com> (raw)
In-Reply-To: <CAD=FV=XJpx_otzW-dWNj1rnXMYab7vPGjo2KNirwyVKtEKat2w@mail.gmail.com>
Doug Anderson wrote:
>
> Hi,
>
Hi,
> On Mon, Jun 23, 2014 at 4:36 AM, Kukjin Kim <kgene.kim@samsung•com> wrote:
> > Naveen Krishna Chatradhi wrote:
> >>
> >> MMC capability for HS200 is parsed in mmc/core/host.c as
> >> dts string "mmc-hs200-1_8v".
> >>
> >> This patch corrects the dts string for Exynos5420 based peach-pit
> >> and Exynos5800 based peach-pi boards.
> >>
> >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung•com>
> >> ---
> >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 +-
> >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 +-
> >> 2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> b/arch/arm/boot/dts/exynos5420-
> >> peach-pit.dts
> >> index 7649982..7dea480 100644
> >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> >> @@ -173,7 +173,7 @@
> >> status = "okay";
> >> num-slots = <1>;
> >> broken-cd;
> >> - caps2-mmc-hs200-1_8v;
> >> + mmc-hs200-1_8v;
> >> supports-highspeed;
> >> non-removable;
> >> card-detect-delay = <200>;
> >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> b/arch/arm/boot/dts/exynos5800-
> >> peach-pi.dts
> >> index 2c2c137..bb3ee76 100644
> >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> >> @@ -171,7 +171,7 @@
> >> status = "okay";
> >> num-slots = <1>;
> >> broken-cd;
> >> - caps2-mmc-hs200-1_8v;
> >> + mmc-hs200-1_8v;
> >> supports-highspeed;
> >> non-removable;
> >> card-detect-delay = <200>;
> >> --
> >> 1.7.9.5
> >
> > Applied, thanks.
>
> As an FYI: this patch (while correct) will likely cause sporadic boot
> failures until Sonny and my patches land:
>
Thanks for your kindly information.
As I replied on other patch, I will holding on until followings land.
> * https://patchwork.kernel.org/patch/4323921/
> mmc: dw_mmc: Make sure we don't get stuck when we get an error
>
> * https://patchwork.kernel.org/patch/4213211/
> mmc: dw_mmc: change to use recommended reset procedure
>
> In the very least we got sporadic boot failures locally when we
> enabled hs200 and didn't have the "don't get stuck" patch. I will
> also note that it would have been nice had this patch title included
> the words exynos and/or pit/pi in it.
>
Yes, as you can see log, I always change the subject with some my rule is
similar with your suggestion when I apply into samsung tree ;-)
Thanks,
Kukjin
prev parent reply other threads:[~2014-06-25 11:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 11:20 [PATCH] ARM: DTS: correct the capability string for mmc0 Naveen Krishna Chatradhi
2014-06-23 11:36 ` Kukjin Kim
2014-06-24 21:33 ` Doug Anderson
2014-06-25 11:19 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='030a01cf9067$63f3ff80$2bdbfe80$@samsung.com' \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox