From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: EXYNOS: enable 4 cores secondary cpu up for exynos5440
Date: Wed, 02 Jan 2013 14:44:15 -0800 [thread overview]
Message-ID: <042701cde93a$b2671f10$17355d30$@samsung.com> (raw)
In-Reply-To: <CAOesGMjCzs6Uh8EEbrNcknGUezyVdbYBJ1M-vXgMYt1jxRPUKQ@mail.gmail.com>
Olof Johansson wrote:
>
> Hi,
>
Hi,
[...]
> It seems better to create a helper function here instead and calling
> that, instead of switching to a conditional open-coded block to this
> function.
>
Yes, sounds good. I will.
> > @@ -178,6 +183,8 @@ static void __init exynos_smp_init_cpus(void)
> >
> > if (soc_is_exynos5250())
> > ncores = 2;
> > + else if (soc_is_exynos5440())
> > + ncores = 4;
>
> In the future it would make sense to get the core count from the
> device tree instead.
>
Agreed.
Thanks.
- Kukjin
next prev parent reply other threads:[~2013-01-02 22:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-31 19:09 [PATCH] ARM: EXYNOS: enable 4 cores secondary cpu up for exynos5440 Kukjin Kim
2013-01-02 20:29 ` Olof Johansson
2013-01-02 22:44 ` Kukjin Kim [this message]
2015-01-07 2:31 ` Ming Lei
2015-01-14 16:19 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='042701cde93a$b2671f10$17355d30$@samsung.com' \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox