From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/4] ARM: SAMSUNG: cleanup of rtc register definitions
Date: Wed, 21 Dec 2011 16:19:53 +0900 [thread overview]
Message-ID: <064701ccbfb0$ef40ea60$cdc2bf20$%kim@samsung.com> (raw)
In-Reply-To: <201112121545.15211.heiko@sntech.de>
Heiko St?bner wrote:
>
> regs-rtc.h uses a mixture of tabs and spaces and also (x<<y)
> to format bits. So, before adding new stuff clean up the formatting
> and also add spaces to the bit definitions (i.e. (x << y) )
>
> Signed-off-by: Heiko Stuebner <heiko@sntech•de>
> ---
> arch/arm/plat-samsung/include/plat/regs-rtc.h | 66
++++++++++++---------
> ----
> 1 files changed, 32 insertions(+), 34 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/include/plat/regs-rtc.h
> b/arch/arm/plat-samsung/include/plat/regs-rtc.h
> index 30b7cc1..d9d9bdc 100644
> --- a/arch/arm/plat-samsung/include/plat/regs-rtc.h
> +++ b/arch/arm/plat-samsung/include/plat/regs-rtc.h
> @@ -18,51 +18,49 @@
> #define S3C2410_INTP_ALM (1 << 1)
> #define S3C2410_INTP_TIC (1 << 0)
>
> -#define S3C2410_RTCCON S3C2410_RTCREG(0x40)
> -#define S3C2410_RTCCON_RTCEN (1<<0)
> -#define S3C2410_RTCCON_CLKSEL (1<<1)
> -#define S3C2410_RTCCON_CNTSEL (1<<2)
> -#define S3C2410_RTCCON_CLKRST (1<<3)
> -#define S3C64XX_RTCCON_TICEN (1<<8)
> +#define S3C2410_RTCCON S3C2410_RTCREG(0x40)
> +#define S3C2410_RTCCON_RTCEN (1 << 0)
> +#define S3C2410_RTCCON_CLKSEL (1 << 1)
> +#define S3C2410_RTCCON_CNTSEL (1 << 2)
> +#define S3C2410_RTCCON_CLKRST (1 << 3)
> +#define S3C64XX_RTCCON_TICEN (1 << 8)
>
> -#define S3C64XX_RTCCON_TICMSK (0xF<<7)
> -#define S3C64XX_RTCCON_TICSHT (7)
> +#define S3C64XX_RTCCON_TICMSK (0xF << 7)
> +#define S3C64XX_RTCCON_TICSHT (7)
>
> -#define S3C2410_TICNT S3C2410_RTCREG(0x44)
> -#define S3C2410_TICNT_ENABLE (1<<7)
> +#define S3C2410_TICNT S3C2410_RTCREG(0x44)
> +#define S3C2410_TICNT_ENABLE (1 << 7)
>
> -#define S3C2410_RTCALM S3C2410_RTCREG(0x50)
> -#define S3C2410_RTCALM_ALMEN (1<<6)
> -#define S3C2410_RTCALM_YEAREN (1<<5)
> -#define S3C2410_RTCALM_MONEN (1<<4)
> -#define S3C2410_RTCALM_DAYEN (1<<3)
> -#define S3C2410_RTCALM_HOUREN (1<<2)
> -#define S3C2410_RTCALM_MINEN (1<<1)
> -#define S3C2410_RTCALM_SECEN (1<<0)
> +#define S3C2410_RTCALM S3C2410_RTCREG(0x50)
> +#define S3C2410_RTCALM_ALMEN (1 << 6)
> +#define S3C2410_RTCALM_YEAREN (1 << 5)
> +#define S3C2410_RTCALM_MONEN (1 << 4)
> +#define S3C2410_RTCALM_DAYEN (1 << 3)
> +#define S3C2410_RTCALM_HOUREN (1 << 2)
> +#define S3C2410_RTCALM_MINEN (1 << 1)
> +#define S3C2410_RTCALM_SECEN (1 << 0)
>
> #define S3C2410_RTCALM_ALL \
> S3C2410_RTCALM_ALMEN | S3C2410_RTCALM_YEAREN | S3C2410_RTCALM_MONEN |\
> S3C2410_RTCALM_DAYEN | S3C2410_RTCALM_HOUREN | S3C2410_RTCALM_MINEN |\
> S3C2410_RTCALM_SECEN
>
> +#define S3C2410_ALMSEC S3C2410_RTCREG(0x54)
> +#define S3C2410_ALMMIN S3C2410_RTCREG(0x58)
> +#define S3C2410_ALMHOUR S3C2410_RTCREG(0x5c)
>
> -#define S3C2410_ALMSEC S3C2410_RTCREG(0x54)
> -#define S3C2410_ALMMIN S3C2410_RTCREG(0x58)
> -#define S3C2410_ALMHOUR S3C2410_RTCREG(0x5c)
> +#define S3C2410_ALMDATE S3C2410_RTCREG(0x60)
> +#define S3C2410_ALMMON S3C2410_RTCREG(0x64)
> +#define S3C2410_ALMYEAR S3C2410_RTCREG(0x68)
>
> -#define S3C2410_ALMDATE S3C2410_RTCREG(0x60)
> -#define S3C2410_ALMMON S3C2410_RTCREG(0x64)
> -#define S3C2410_ALMYEAR S3C2410_RTCREG(0x68)
> -
> -#define S3C2410_RTCRST S3C2410_RTCREG(0x6c)
> -
> -#define S3C2410_RTCSEC S3C2410_RTCREG(0x70)
> -#define S3C2410_RTCMIN S3C2410_RTCREG(0x74)
> -#define S3C2410_RTCHOUR S3C2410_RTCREG(0x78)
> -#define S3C2410_RTCDATE S3C2410_RTCREG(0x7c)
> -#define S3C2410_RTCDAY S3C2410_RTCREG(0x80)
> -#define S3C2410_RTCMON S3C2410_RTCREG(0x84)
> -#define S3C2410_RTCYEAR S3C2410_RTCREG(0x88)
> +#define S3C2410_RTCRST S3C2410_RTCREG(0x6c)
>
> +#define S3C2410_RTCSEC S3C2410_RTCREG(0x70)
> +#define S3C2410_RTCMIN S3C2410_RTCREG(0x74)
> +#define S3C2410_RTCHOUR S3C2410_RTCREG(0x78)
> +#define S3C2410_RTCDATE S3C2410_RTCREG(0x7c)
> +#define S3C2410_RTCDAY S3C2410_RTCREG(0x80)
> +#define S3C2410_RTCMON S3C2410_RTCREG(0x84)
> +#define S3C2410_RTCYEAR S3C2410_RTCREG(0x88)
>
> #endif /* __ASM_ARCH_REGS_RTC_H */
> --
> 1.7.5.4
Looks good to me, but how about cleanup useless definitions together like
following?
Actually, S3C2410_RTCCON_CLKSEL, S3C64XX_RTCCON_TICMSK,
S3C64XX_RTCCON_TICSHT, S3C2410_RTCALM_ALL, S3C2410_RTCRST and S3C2410_RTCDAY
are not used.
And I'm not sure we really need to define the S3C2410_RTCREG(x), but this
can be sorted out next time with similar others.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung•com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2011-12-21 7:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 14:43 [PATCH v2 0/4] Implement RTC support for S3C2443/S3C2416/S3C2450 Heiko Stübner
2011-12-12 14:45 ` [PATCH 1/4] ARM: SAMSUNG: cleanup of rtc register definitions Heiko Stübner
2011-12-21 7:19 ` Kukjin Kim [this message]
2011-12-12 14:46 ` [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block Heiko Stübner
2011-12-12 14:48 ` [PATCH 3/4] rtc-s3c: add variants for S3C2443 and S3C2416 Heiko Stübner
2011-12-12 14:49 ` [PATCH 4/4] ARM: S3C2443/S3C2416: add s3c_rtc_setname and rename rtc devices Heiko Stübner
2011-12-21 7:25 ` [PATCH v2 0/4] Implement RTC support for S3C2443/S3C2416/S3C2450 Kukjin Kim
2011-12-21 8:22 ` Heiko Stübner
2011-12-23 11:43 ` [rtc-linux] " Mark Brown
2011-12-26 1:01 ` Alessandro Zummo
2011-12-27 0:44 ` Kukjin Kim
2011-12-27 22:49 ` Alessandro Zummo
2011-12-29 3:28 ` Kukjin Kim
-- strict thread matches above, loose matches on Subject: below --
2011-12-21 9:14 [PATCH v3 " Heiko Stübner
2011-12-21 9:16 ` [PATCH 1/4] ARM: SAMSUNG: cleanup of rtc register definitions Heiko Stübner
2012-01-04 14:12 ` [PATCH 2/4] rtc-s3c: make room for more variants in devicetree block Heiko Stübner
2012-01-04 14:14 ` [PATCH v4 0/4] Implement RTC support for S3C2443/S3C2416/S3C2450 Heiko Stübner
2012-01-04 14:15 ` [PATCH 1/4] ARM: SAMSUNG: cleanup of rtc register definitions Heiko Stübner
2012-01-04 22:14 ` Russell King - ARM Linux
2011-12-09 9:46 [PATCH 0/4] Implement RTC support for S3C2443/S3C2416/S3C2450 Heiko Stübner
2011-12-09 9:47 ` [PATCH 1/4] ARM: SAMSUNG: cleanup of rtc register definitions Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='064701ccbfb0$ef40ea60$cdc2bf20$%kim@samsung.com' \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox