From: <Claudiu.Beznea@microchip•com>
To: <kamel.bouhara@bootlin•com>, <wsa@the-dreams•de>,
<linux-i2c@vger•kernel.org>, <linux-kernel@vger•kernel.org>,
<Nicolas.Ferre@microchip•com>, <alexandre.belloni@bootlin•com>,
<Ludovic.Desroches@microchip•com>,
<linux-arm-kernel@lists•infradead.org>
Cc: devicetree@vger•kernel.org, thomas.petazzoni@bootlin•com
Subject: Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery
Date: Fri, 4 Oct 2019 09:35:23 +0000 [thread overview]
Message-ID: <08e99a4b-851e-0bee-4c5a-8578b42c283e@microchip.com> (raw)
In-Reply-To: <20191002144658.7718-3-kamel.bouhara@bootlin.com>
Hi Kamel,
On 02.10.2019 17:46, Kamel Bouhara wrote:
> +static int at91_init_twi_recovery_info(struct platform_device *pdev,
> + struct at91_twi_dev *dev)
> +{
> + struct i2c_bus_recovery_info *rinfo = &dev->rinfo;
> +
> + dev->pinctrl = devm_pinctrl_get(&pdev->dev);
> + if (!dev->pinctrl || IS_ERR(dev->pinctrl)) {
You may use IS_ERR_OR_NULL() here.
> + dev_info(dev->dev, "can't get pinctrl, bus recovery not supported\n");
> + return PTR_ERR(dev->pinctrl);
> + }
> +
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-04 9:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 14:46 [PATCH 0/4] i2c bus recovery for Microchip SoCs Kamel Bouhara
2019-10-02 14:46 ` [PATCH 1/4] dt-bindings: i2c: at91: document optional bus recovery properties Kamel Bouhara
2019-10-02 14:46 ` [PATCH 2/4] i2c: at91: implement i2c bus recovery Kamel Bouhara
2019-10-04 9:35 ` Claudiu.Beznea [this message]
2019-10-04 20:39 ` Uwe Kleine-König
2019-10-07 10:17 ` Claudiu.Beznea
2019-10-09 13:55 ` Ludovic Desroches
2019-10-09 14:01 ` Alexandre Belloni
2019-10-10 6:54 ` Ludovic Desroches
2019-10-24 12:29 ` Kamel Bouhara
2019-10-25 7:04 ` Ludovic.Desroches
2019-10-21 20:20 ` Wolfram Sang
2019-10-22 7:59 ` Kamel Bouhara
2019-10-24 14:08 ` Codrin.Ciubotariu
2019-10-24 15:07 ` Wolfram Sang
2019-10-25 1:14 ` Phil Reid
2020-08-25 13:28 ` Wolfram Sang
2020-08-25 23:44 ` Phil Reid
2019-10-02 14:46 ` [PATCH 3/4] ARM: at91/dt: sama5d3: add i2c gpio pinctrl Kamel Bouhara
2019-10-02 14:46 ` [PATCH 4/4] ARM: at91/dt: sama5d4: " Kamel Bouhara
2019-10-15 19:10 ` [PATCH 0/4] i2c bus recovery for Microchip SoCs Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08e99a4b-851e-0bee-4c5a-8578b42c283e@microchip.com \
--to=claudiu.beznea@microchip$(echo .)com \
--cc=Ludovic.Desroches@microchip$(echo .)com \
--cc=Nicolas.Ferre@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=kamel.bouhara@bootlin$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=wsa@the-dreams$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox