From: Nicolas Ferre <nicolas.ferre@microchip•com>
To: Manikandan M - I67131 <Manikandan.M@microchip•com>,
Claudiu Beznea <claudiu.beznea@tuxon•dev>
Cc: "alexandre.belloni@bootlin•com" <alexandre.belloni@bootlin•com>,
"Frank.Li@nxp•com" <Frank.Li@nxp•com>,
"robh@kernel•org" <robh@kernel•org>,
"krzk+dt@kernel•org" <krzk+dt@kernel•org>,
"conor+dt@kernel•org" <conor+dt@kernel•org>,
"linux@armlinux•org.uk" <linux@armlinux•org.uk>,
"mturquette@baylibre•com" <mturquette@baylibre•com>,
"sboyd@kernel•org" <sboyd@kernel•org>,
"tytso@mit•edu" <tytso@mit•edu>,
Aubin Constans - M51280 <Aubin.Constans@microchip•com>,
Ryan Wanner - C70674 <Ryan.Wanner@microchip•com>,
Romain Sioen - M70749 <Romain.Sioen@microchip•com>,
"durai.manickamkr@microchip•com" <durai.manickamkr@microchip•com>,
Cristian Birsan - M91496 <Cristian.Birsan@microchip•com>,
"adrian.hunter@intel•com" <adrian.hunter@intel•com>,
"jarkko.nikula@linux•intel.com" <jarkko.nikula@linux•intel.com>,
"npitre@baylibre•com" <npitre@baylibre•com>,
"linux-i3c@lists•infradead.org" <linux-i3c@lists•infradead.org>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"linux-clk@vger•kernel.org" <linux-clk@vger•kernel.org>
Subject: Re: [PATCH v6 4/5] ARM: dts: microchip: add I3C controller
Date: Mon, 18 May 2026 09:27:55 +0200 [thread overview]
Message-ID: <0ae90352-2099-4d3d-a55c-40a6e090fde4@microchip.com> (raw)
In-Reply-To: <515e89f3-fca9-477c-be4d-be9ed9428d5f@microchip.com>
On 18/05/2026 at 08:10, Manikandan M - I67131 wrote:
> Hi Claudiu,
>
> On 16/05/26 9:37 pm, Claudiu Beznea wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know
>> the content is safe
>>
>> Hi, Manikandan,
>>
>> On 5/7/26 11:48, Manikandan Muralidharan wrote:
>>> From: Durai Manickam KR <durai.manickamkr@microchip•com>
>>>
>>> Add I3C controller for sama7d65 SoC.
>>>
>>> Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip•com>
>>> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip•com>
>>> ---
>>> Changes in v3:
>>> - Remove clock-names property as driver enables the clk in bulk
>>>
>>> arch/arm/boot/dts/microchip/sama7d65.dtsi | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi
>>> b/arch/arm/boot/dts/microchip/sama7d65.dtsi
>>> index 67253bbc08df..ec200848c153 100644
>>> --- a/arch/arm/boot/dts/microchip/sama7d65.dtsi
>>> +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi
>>> @@ -1055,5 +1055,13 @@ gic: interrupt-controller@e8c11000 {
>>> #address-cells = <0>;
>>> interrupt-controller;
>>> };
>>> +
>>> + i3c: i3c@e9000000 {
>>> + compatible = "microchip,sama7d65-i3c-hci";
>>> + reg = <0xe9000000 0x300>;
>>
>> From manual at [1] I see the size of I3CC region is 0x1000. Unless that is
>> wrong I think we should use 0x1000 to properly describe de HW. Please
>> let me
>> know and I can do it while applying.
The memory map simply describes what is the next memory boundary
assigned (or void in this case), not the actual size of the IP user
interface.
So we took the opportunity to avoid mapping unused memory.
> According to Table 78.6 (Register Summary), the I3CC register space
> extends up to offset 0x258, Ideally the mapping should have been 0x400
The underlying memory mapping certainly does what is best, so I would
cling to being the closest to last register described. So your 0x300
value looks very good to me.
Best regards,
Nicolas
> (next power of 2 considering the memory region alignment), using 0x1000
> is also acceptable. Please advise which value is preferred.
>
>> Thank you,
>> Claudiu
>>
>> [1]
>> https://ww1.microchip.com/downloads/aemDocuments/documents/MPU32/ProductDocuments/DataSheets/SAMA7D6-Series-Data-Sheet-DS60001851.pdf
>>
>>> + interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&pmc PMC_TYPE_PERIPHERAL 105>, <&pmc
>>> PMC_TYPE_GCK 105>;
>>> + status = "disabled";
>>> + };
>>> };
>>> };
>>
>
next prev parent reply other threads:[~2026-05-18 7:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 8:48 [PATCH v6 0/5] Add microchip sama7d65 SoC I3C support Manikandan Muralidharan
2026-05-07 8:48 ` [PATCH v6 1/5] dt-bindings: i3c: mipi-i3c-hci: add Microchip SAMA7D65 compatible Manikandan Muralidharan
2026-05-07 16:34 ` Frank Li
2026-05-07 8:48 ` [PATCH v6 2/5] clk: at91: sama7d65: add peripheral clock for I3C Manikandan Muralidharan
2026-05-16 16:06 ` Claudiu Beznea
2026-05-07 8:48 ` [PATCH v6 3/5] i3c: mipi-i3c-hci: add microchip sama7d65 SoC compatible with the required quirk Manikandan Muralidharan
2026-05-07 16:34 ` Frank Li
2026-05-07 8:48 ` [PATCH v6 4/5] ARM: dts: microchip: add I3C controller Manikandan Muralidharan
2026-05-16 16:07 ` Claudiu Beznea
2026-05-18 6:10 ` Manikandan.M
2026-05-18 7:27 ` Nicolas Ferre [this message]
2026-05-07 8:48 ` [PATCH v6 5/5] ARM: configs: at91: sama7: add sama7d65 i3c-hci Manikandan Muralidharan
2026-05-16 16:07 ` Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ae90352-2099-4d3d-a55c-40a6e090fde4@microchip.com \
--to=nicolas.ferre@microchip$(echo .)com \
--cc=Aubin.Constans@microchip$(echo .)com \
--cc=Cristian.Birsan@microchip$(echo .)com \
--cc=Frank.Li@nxp$(echo .)com \
--cc=Manikandan.M@microchip$(echo .)com \
--cc=Romain.Sioen@microchip$(echo .)com \
--cc=Ryan.Wanner@microchip$(echo .)com \
--cc=adrian.hunter@intel$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=claudiu.beznea@tuxon$(echo .)dev \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=durai.manickamkr@microchip$(echo .)com \
--cc=jarkko.nikula@linux$(echo .)intel.com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-i3c@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mturquette@baylibre$(echo .)com \
--cc=npitre@baylibre$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=sboyd@kernel$(echo .)org \
--cc=tytso@mit$(echo .)edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox