From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 0/4] ARM: S3C24XX: cleanup debug macro/earlyprintk
Date: Tue, 06 May 2014 13:16:14 +0900 [thread overview]
Message-ID: <0cc401cf68e1$eb87f580$c297e080$@samsung.com> (raw)
In-Reply-To: <1856986.kkQFKFg1L2@phil>
Heiko St?bner wrote:
>
> This series tries to simplify the s3c24xx debug macro, removing
> dependencies
> on mach/ includes, static mappings and finally moving it into
> include/debug.
>
I think, it's good way :)
> The one slightly invasive change is the need for the developer to select
> the uart type by himself, which gets rid of the debug macro trying to
> determine the uart type itself.
>
> But as usage of the debug-uart is not the common case - especially in a
> multiplatform scenario - I didn't worry to much.
>
Yeah, I also don't want s3c24xx to support multiplatform in near future.
> Based on 3.15-rc1 and tested on a S3C2442 Openmoko Freerunner (GTA02)
>
> changes since v1:
> - do not introduce a secondary choice option, instead implement the
> s3c2410 debug uarts as separate options
>
> Heiko Stuebner (4):
> ARM: compressed/head.S: remove s3c24xx special case
> ARM: S3C24XX: trim down debug uart handling
> ARM: S3C24XX: use generic DEBUG_UART_PHY/_VIRT in debug macro
> ARM: S3C24XX: move debug-macro.S into the common space
>
> arch/arm/Kconfig.debug | 54 +++++++++++-
> arch/arm/boot/compressed/head.S | 5 --
> arch/arm/include/debug/s3c24xx.S | 46 +++++++++++
> arch/arm/mach-s3c24xx/Kconfig | 28 -------
> arch/arm/mach-s3c24xx/include/mach/debug-macro.S | 101 ------------------
> -----
> 5 files changed, 98 insertions(+), 136 deletions(-)
> create mode 100644 arch/arm/include/debug/s3c24xx.S
> delete mode 100644 arch/arm/mach-s3c24xx/include/mach/debug-macro.S
>
> --
> 1.9.0
Basically I'm OK on this series but need to get review from Russell?
Thanks,
Kukjin
next prev parent reply other threads:[~2014-05-06 4:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 13:21 [PATCH v2 0/4] ARM: S3C24XX: cleanup debug macro/earlyprintk Heiko Stübner
2014-04-24 13:22 ` [PATCH v2 1/4] ARM: compressed/head.S: remove s3c24xx special case Heiko Stübner
2014-04-24 13:23 ` [PATCH v2 2/4] ARM: S3C24XX: trim down debug uart handling Heiko Stübner
2014-04-24 13:23 ` [PATCH v2 3/4] ARM: S3C24XX: use generic DEBUG_UART_PHY/_VIRT in debug macro Heiko Stübner
2014-04-24 13:24 ` [PATCH v2 4/4] ARM: S3C24XX: move debug-macro.S into the common space Heiko Stübner
2014-05-06 4:16 ` Kukjin Kim [this message]
2014-05-06 8:44 ` [PATCH v2 0/4] ARM: S3C24XX: cleanup debug macro/earlyprintk Heiko Stübner
2014-05-13 5:32 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0cc401cf68e1$eb87f580$c297e080$@samsung.com' \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox