Subject: Re: [PATCH] KVM: arm: Fix build after MMIO cleanup

From: Marc Zyngier <[email-masked]>
Date: Tue, 21 Jan 2020 11:43:08 +0000

On 2020-01-21 03:10, Olof Johansson wrote:
> Looks like the mmio_decode field was accidentally left in on 32-bit:
> 
> In file included from /build/include/linux/kvm_host.h:36,
>                  from /build/arch/arm/kernel/asm-offsets.c:15:
> arch/arm/include/asm/kvm_host.h:205:20: error: field 'mmio_decode' has
> incomplete type
> 
> Fixes: 480bfa6478c8 ("KVM: arm/arm64: Cleanup MMIO handling")
> Cc: Marc Zyngier <[email-masked]>
> Signed-off-by: Olof Johansson <[email-masked]>
> ---
>  arch/arm/include/asm/kvm_host.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm/include/asm/kvm_host.h 
> b/arch/arm/include/asm/kvm_host.h
> index acf4c87e8321a..bd2233805d995 100644
> --- a/arch/arm/include/asm/kvm_host.h
> +++ b/arch/arm/include/asm/kvm_host.h
> @@ -201,9 +201,6 @@ struct kvm_vcpu_arch {
>  	 /* Don't run the guest (internal implementation need) */
>  	bool pause;
> 
> -	/* IO related fields */
> -	struct kvm_decode mmio_decode;
> -
>  	/* Cache some mmu pages needed inside spinlock regions */
>  	struct kvm_mmu_memory_cache mmu_page_cache;

Ouch. Thanks for that. I've squashed the fix in the original patch
(which I didn't really intend to be in -next just yet - not quite
sure what I did here).

         M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel