From: shc_work@mail•ru (Alexander Shiyan)
To: linux-arm-kernel@lists•infradead.org
Subject: Re[2]: [PATCH] regulator: mc13783: Add device tree probe support
Date: Mon, 08 Apr 2013 20:46:39 +0400 [thread overview]
Message-ID: <1365439599.786794300@f48.mail.ru> (raw)
In-Reply-To: <20130407192157.GQ6597@opensource.wolfsonmicro.com>
Hello.
> On Sun, Apr 07, 2013 at 09:02:11PM +0400, Alexander Shiyan wrote:
> > Patch adds device tree probe support for mc13783-regulator driver.
>
> I'd expect to see a document describing the binding for any new binding.
OK.
> > + if (num_parsed != num_regulators) {
> > + dev_warn(&pdev->dev,
> > + "parsed %d != regulators %d - check your device tree!\n",
> > + num_parsed, num_regulators);
> >
> > - init_data = &pdata->regulators[i];
> > - desc = &mc13783_regulators[init_data->id].desc;
> > + num_regulators = num_parsed;
> > + priv->num_regulators = num_regulators;
>
> Why is this something we warn about? Users should be able to omit
> unused regulators, no point in adding nodes that don't have any real
> information.
Warning is appear on nonexistent regulators names only.
I will rewrite warning procedure in the v2 globally for mc13xx.
Thanks.
---
prev parent reply other threads:[~2013-04-08 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 17:02 [PATCH] regulator: mc13783: Add device tree probe support Alexander Shiyan
2013-04-07 19:21 ` Mark Brown
2013-04-08 16:46 ` Alexander Shiyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365439599.786794300@f48.mail.ru \
--to=shc_work@mail$(echo .)ru \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox