From: shc_work@mail•ru (Alexander Shiyan)
To: linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH 4/4] ARM: dts: keystone-k2hk: add dsp gpio controllers nodes
Date: Wed, 13 Aug 2014 20:06:24 +0400 [thread overview]
Message-ID: <1407945984.545232249@f170.i.mail.ru> (raw)
In-Reply-To: <1407946582-20927-5-git-send-email-grygorii.strashko@ti.com>
Wed, 13 Aug 2014 19:16:22 +0300 ?? Grygorii Strashko <grygorii.strashko@ti•com>:
> Add Keystone 2 DSP GPIO nodes.
> DSP GPIO banks 0-7 correspond to DSP0-DSP7
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti•com>
> ---
> arch/arm/boot/dts/k2hk.dtsi | 56 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 56 insertions(+)
>
> diff --git a/arch/arm/boot/dts/k2hk.dtsi b/arch/arm/boot/dts/k2hk.dtsi
> index 321ba2f..009e180 100644
> --- a/arch/arm/boot/dts/k2hk.dtsi
> +++ b/arch/arm/boot/dts/k2hk.dtsi
> @@ -50,5 +50,61 @@
> #interrupt-cells = <1>;
> ti,syscon-dev = <&devctrl 0x2a0>;
> };
> +
> + dspgpio0: keystone_dsp_gpio at 02620240 {
> + compatible = "ti,keystone-mctrl-gpio";
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio,syscon-dev = <&devctrl 0x240>;
> + };
> +
> + dspgpio1: keystone_dsp_gpio at 2620244 {
> + compatible = "ti,keystone-mctrl-gpio";
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio,syscon-dev = <&devctrl 0x244>;
> + };
...
> + dspgpio7: keystone_dsp_gpio at 262025C {
> + compatible = "ti,keystone-mctrl-gpio";
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio,syscon-dev = <&devctrl 0x25c>;
> + };
So, devctrl is a syscon device and this DTS introduce several
identical GPIO descriptions?
On my opinion this should be placed in the gpio-syscon.c,
where you can add support for ti,keystone-dsp0{..7}-gpio.
Such change will avoid parts 2 and 3 of this patch.
static const struct syscon_gpio_data ti_keystone_dsp0_gpio = {
.compatible = "ti,keystone-syscon",
.dat_bit_offset = 0x240 * 8,
...
.set = etc...
};
---
next prev parent reply other threads:[~2014-08-13 16:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 16:16 [PATCH 0/4] gpio: syscon: reuse for keystone 2 socs Grygorii Strashko
2014-08-13 16:16 ` [PATCH 1/4] gpio: syscon: add soc specific callback to assign output value Grygorii Strashko
2014-08-29 6:19 ` Linus Walleij
2014-09-01 14:55 ` Grygorii Strashko
2014-08-13 16:16 ` [PATCH 2/4] gpio: syscon: retrive syscon node and regs offsets from dt Grygorii Strashko
2014-08-13 16:16 ` [PATCH 3/4] gpio: syscon: reuse for keystone 2 socs Grygorii Strashko
2014-08-29 5:53 ` Linus Walleij
2014-08-13 16:16 ` [PATCH 4/4] ARM: dts: keystone-k2hk: add dsp gpio controllers nodes Grygorii Strashko
2014-08-13 16:06 ` Alexander Shiyan [this message]
2014-08-14 12:13 ` Grygorii Strashko
2014-08-14 12:12 ` Alexander Shiyan
2014-08-14 15:57 ` Grygorii Strashko
2014-08-14 15:26 ` Alexander Shiyan
2014-08-14 16:54 ` Grygorii Strashko
2014-08-21 16:23 ` [PATCH v2 0/3] gpio: syscon: reuse for keystone 2 socs Grygorii Strashko
2014-08-21 16:23 ` [PATCH v2 1/3] gpio: syscon: add soc specific callback to assign output value Grygorii Strashko
2014-08-21 16:23 ` [PATCH v2 2/3] gpio: syscon: reuse for keystone 2 socs Grygorii Strashko
2014-08-21 16:23 ` [PATCH v2 3/3] ARM: dts: keystone-k2hk: add dsp gpio controllers nodes Grygorii Strashko
2014-08-21 16:47 ` Alexander Shiyan
2014-08-21 16:51 ` [PATCH v2 0/3] gpio: syscon: reuse for keystone 2 socs Alexander Shiyan
2014-08-28 17:32 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407945984.545232249@f170.i.mail.ru \
--to=shc_work@mail$(echo .)ru \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox