From: kiran.padwal@smartplayin•com (kiran.padwal at smartplayin.com)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: apq8064: Add pinmux and i2c pinctrl nodes
Date: Mon, 18 Aug 2014 11:48:03 -0400 (EDT) [thread overview]
Message-ID: <1408376883.684512744@apps.rackspace.com> (raw)
In-Reply-To: <1408129739.03949271@apps.rackspace.com>
On Friday, August 15, 2014 3:08pm, kiran.padwal at smartplayin.com said:
>
> On Thursday, August 14, 2014 6:37pm, "Bjorn Andersson" <bjorn@kryo•se> said:
>
>> On Thu, Aug 14, 2014 at 12:20 AM, Kiran Padwal
>> <kiran.padwal@smartplayin•com> wrote:
>>> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi
>>> b/arch/arm/boot/dts/qcom-apq8064.dtsi
>>> index 92bf793..fbebf5c 100644
>>> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
>>> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
>>> @@ -70,6 +70,17 @@
>>> ranges;
>>> compatible = "simple-bus";
>>>
>>> + qcom_pinmux: pinmux at 800000 {
>>
>> There are (at least) three different pinmuxes in these platforms: TLMM, PMIC
>> GPIO, PMIC MPP. Also this is the phandle that is used to reference the gpio
>> chip throughout the board.
>>
>> So I would like to suggest that we name it "tlmm" or like in the downstream
>> kernel "msmgpio".
>
> ok. How about "qcomgpio" or rename it to msmgpio?
Thanks for suggestion, I will rename it to "tlmm".
>
>>
>>> + compatible = "qcom,apq8064-pinctrl";
>>> + reg = <0x800000 0x4000>;
>>> +
>>> + gpio-controller;
>>> + #gpio-cells = <2>;
>>> + interrupt-controller;
>>> + #interrupt-cells = <2>;
>>> + interrupts = <0 32 0x4>;
>>
>> I must have gotten this wrong in the dt binding example, sorry about that.
>> interrupts should be <0 16 0x4>.
>
> Thanks for information. I will update that.
>
>>
>>> + };
>>
>> Regards,
>> Bjorn
>>
>
>
>
next parent reply other threads:[~2014-08-18 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1408129739.03949271@apps.rackspace.com>
2014-08-18 15:48 ` kiran.padwal at smartplayin.com [this message]
2014-08-14 7:20 [PATCH] ARM: apq8064: Add pinmux and i2c pinctrl nodes Kiran Padwal
2014-08-14 22:37 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408376883.684512744@apps.rackspace.com \
--to=kiran.padwal@smartplayin$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox