From: kiran.padwal@smartplayin•com (kiran.padwal at smartplayin.com)
To: linux-arm-kernel@lists•infradead.org
Subject: RE: [PATCH v2 4/4] clk: Use ww_mutexes for clk_prepare_{lock/unlock}
Date: Thu, 4 Sep 2014 06:11:30 -0400 (EDT) [thread overview]
Message-ID: <1409825490.812215098@apps.rackspace.com> (raw)
In-Reply-To: <1409792466-5092-5-git-send-email-sboyd@codeaurora.org>
Hi Stephen,
On Wednesday, September 3, 2014 9:01pm, "Stephen Boyd" <sboyd@codeaurora•org> said:
> Changing the rate of a "slow" clock can take 10s of milliseconds
> while changing the rate of a "fast" clock can be done in a few
<snip>
> -static void clk_prepare_lock(void)
> +static void __clk_unlock(struct list_head *list)
> +{
> + struct clk *entry, *temp;
> +
> + list_for_each_entry_safe (entry, temp, list, ww_list) {
Checkpatch warning for above line,
WARNING: space prohibited between function name and open parenthesis '('
> + list_del_init(&entry->ww_list);
> + ww_mutex_unlock(&entry->lock);
> + }
> +}
> +
> +static void clk_unlock(struct list_head *list, struct ww_acquire_ctx *ctx)
> +{
<snip>
> + ww_acquire_init(ctx, &prepare_ww_class);
> + do {
> + ret = __clk_prepare_lock(clk, list, ctx);
> + } while (ret == -EDEADLK);
> + ww_acquire_done(ctx);
> +}
> +
> +static int __clk_unprepare_lock(struct clk *clk, struct list_head *list,
> + struct ww_acquire_ctx *ctx)
Checkpatch error for above line,
ERROR: code indent should use tabs where possible
Best Regards,
Kiran Padwal
> +{
> + int ret;
> +
> + do {
> + ret = clk_lock_one(clk, list, ctx);
> + if (ret == -EDEADLK)
> + return ret;
> +
> + if (clk->prepare_count > 1)
> + break;
> + } while ((clk = clk->parent));
> +
> + return 0;
> +}
next prev parent reply other threads:[~2014-09-04 10:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 1:01 [PATCH v2 0/4] Use wound/wait mutexes in the common clock framework Stephen Boyd
2014-09-04 1:01 ` [PATCH v2 1/4] clk: Recalc rate and accuracy in underscore functions if not caching Stephen Boyd
2014-09-04 1:01 ` [PATCH v2 2/4] clk: Make __clk_lookup() use a list instead of tree search Stephen Boyd
2014-09-04 1:01 ` [PATCH v2 3/4] clk: Use lockless functions for debug printing Stephen Boyd
2014-09-04 1:01 ` [PATCH v2 4/4] clk: Use ww_mutexes for clk_prepare_{lock/unlock} Stephen Boyd
2014-09-04 10:11 ` kiran.padwal at smartplayin.com [this message]
2014-09-28 2:41 ` Mike Turquette
2014-09-30 0:12 ` Stephen Boyd
2014-10-08 1:09 ` Stephen Boyd
2014-10-09 2:59 ` Mike Turquette
2014-10-10 8:24 ` Peter De Schrijver
2014-10-11 0:20 ` Stephen Boyd
2014-10-13 8:23 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409825490.812215098@apps.rackspace.com \
--to=kiran.padwal@smartplayin$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox