From: joe@perches•com (Joe Perches)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction
Date: Sun, 26 Oct 2014 23:46:11 -0700 [thread overview]
Message-ID: <1414392371.8884.2.camel@perches.com> (raw)
In-Reply-To: <35FD53F367049845BC99AC72306C23D103E010D18257@CNBJMBX05.corpusers.net>
On Mon, 2014-10-27 at 14:37 +0800, Wang, Yalin wrote:
> this change add CONFIG_HAVE_ARCH_BITREVERSE config option,
> so that we can use arm/arm64 rbit instruction to do bitrev operation
> by hardware.
>
> Signed-off-by: Yalin Wang <yalin.wang@sonymobile•com>
> ---
> arch/arm/Kconfig | 1 +
> arch/arm/include/asm/bitrev.h | 21 +++++++++++++++++++++
> arch/arm64/Kconfig | 1 +
> arch/arm64/include/asm/bitrev.h | 21 +++++++++++++++++++++
> include/linux/bitrev.h | 9 +++++++++
> lib/Kconfig | 9 +++++++++
> lib/bitrev.c | 2 ++
> 7 files changed, 64 insertions(+)
> create mode 100644 arch/arm/include/asm/bitrev.h
> create mode 100644 arch/arm64/include/asm/bitrev.h
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 89c4b5c..426cbcc 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -16,6 +16,7 @@ config ARM
> select DCACHE_WORD_ACCESS if HAVE_EFFICIENT_UNALIGNED_ACCESS
> select GENERIC_ALLOCATOR
> select GENERIC_ATOMIC64 if (CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI)
> + select HAVE_ARCH_BITREVERSE if (CPU_V7M || CPU_V7)
> select GENERIC_CLOCKEVENTS_BROADCAST if SMP
> select GENERIC_IDLE_POLL_SETUP
> select GENERIC_IRQ_PROBE
> diff --git a/arch/arm/include/asm/bitrev.h b/arch/arm/include/asm/bitrev.h
> new file mode 100644
> index 0000000..0df5866
> --- /dev/null
> +++ b/arch/arm/include/asm/bitrev.h
> @@ -0,0 +1,21 @@
> +#ifndef __ASM_ARM_BITREV_H
> +#define __ASM_ARM_BITREV_H
> +
> +static inline __attribute_const__ u32 __arch_bitrev32(u32 x)
> +{
> + __asm__ ("rbit %0, %1" : "=r" (x) : "r" (x));
> + return x;
> +}
> +
> +static inline __attribute_const__ u16 __arch_bitrev16(u16 x)
> +{
> + return __arch_bitrev32((u32)x) >> 16;
> +}
> +
> +static inline __attribute_const__ u8 __arch_bitrev8(u8 x)
> +{
> + return __arch_bitrev32((u32)x) >> 24;
> +}
> +
> +#endif
> +
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 9532f8d..263c28c 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -36,6 +36,7 @@ config ARM64
> select HARDIRQS_SW_RESEND
> select HAVE_ARCH_AUDITSYSCALL
> select HAVE_ARCH_JUMP_LABEL
> + select HAVE_ARCH_BITREVERSE
> select HAVE_ARCH_KGDB
> select HAVE_ARCH_TRACEHOOK
> select HAVE_BPF_JIT
> diff --git a/arch/arm64/include/asm/bitrev.h b/arch/arm64/include/asm/bitrev.h
> new file mode 100644
> index 0000000..5d24c11
> --- /dev/null
> +++ b/arch/arm64/include/asm/bitrev.h
> @@ -0,0 +1,21 @@
> +#ifndef __ASM_ARM_BITREV_H
> +#define __ASM_ARM_BITREV_H
> +
> +static inline __attribute_const__ u32 __arch_bitrev32(u32 x)
> +{
> + __asm__ ("rbit %w0, %w1" : "=r" (x) : "r" (x));
> + return x;
> +}
> +
> +static inline __attribute_const__ u16 __arch_bitrev16(u16 x)
> +{
> + return __arch_bitrev32((u32)x) >> 16;
> +}
> +
> +static inline __attribute_const__ u8 __arch_bitrev8(u8 x)
> +{
> + return __arch_bitrev32((u32)x) >> 24;
> +}
> +
> +#endif
> +
> diff --git a/include/linux/bitrev.h b/include/linux/bitrev.h
> index 7ffe03f..ef5b2bb 100644
> --- a/include/linux/bitrev.h
> +++ b/include/linux/bitrev.h
> @@ -3,6 +3,14 @@
>
> #include <linux/types.h>
>
> +#ifdef CONFIG_HAVE_ARCH_BITREVERSE
> +#include <asm/bitrev.h>
> +
> +#define bitrev32 __arch_bitrev32
> +#define bitrev16 __arch_bitrev16
> +#define bitrev8 __arch_bitrev8
> +
> +#else
> extern u8 const byte_rev_table[256];
If this is done, the direct uses of byte_rev_table in
drivers/net/wireless/ath/carl9170/phy.c and
sound/usb/6fire/firmware.c should be converted too?
next prev parent reply other threads:[~2014-10-27 6:46 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 5:10 [PATCH RFC] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit Wang, Yalin
[not found] ` <35FD53F367049845BC99AC72306C23D103E010D18257@CNBJMBX05.corpusers.net>
2014-10-27 6:46 ` Joe Perches [this message]
2014-10-27 7:13 ` [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction Wang, Yalin
2014-10-28 21:18 ` [PATCH] carl9170: Convert byte_rev_table uses to bitrev8 Joe Perches
2014-10-28 21:22 ` [PATCH] 6fire: " Joe Perches
2014-10-29 2:42 ` Wang, Yalin
2014-10-29 3:06 ` Joe Perches
2014-10-29 3:10 ` Wang, Yalin
2014-10-29 3:28 ` [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction Rob Herring
2014-10-29 5:20 ` Wang, Yalin
[not found] ` <35FD53F367049845BC99AC72306C23D103E010D1825F@CNBJMBX05.corpusers.net>
2014-10-29 5:21 ` [RFC V4 1/3] add " Joe Perches
2014-10-29 5:36 ` Wang, Yalin
[not found] ` <35FD53F367049845BC99AC72306C23D103E010D18260@CNBJMBX05.corpusers.net>
[not found] ` <35FD53F367049845BC99AC72306C23D103E010D18261@CNBJMBX05.corpusers.net>
[not found] ` <35FD53F367049845BC99AC72306C23D103E010D18264@CNBJMBX05.corpusers.net>
[not found] ` <35FD53F367049845BC99AC72306C23D103E010D18265@CNBJMBX05.corpusers.net>
[not found] ` <35FD53F367049845BC99AC72306C23D103E010D18266@CNBJMBX05.corpusers.net>
2014-10-30 12:01 ` [RFC V5 3/3] arm64:add bitrev.h file " Will Deacon
2014-10-30 12:26 ` Ard Biesheuvel
2014-10-30 13:57 ` Will Deacon
[not found] ` <35FD53F367049845BC99AC72306C23D103E010D18272@CNBJMBX05.corpusers.net>
[not found] ` <35FD53F367049845BC99AC72306C23D103E010D18273@CNBJMBX05.corpusers.net>
2014-10-31 7:54 ` [RFC V6 2/3] add CONFIG_HAVE_ARCH_BITREVERSE " Wang, Yalin
[not found] ` <35FD53F367049845BC99AC72306C23D103E010D18275@CNBJMBX05.corpusers.net>
[not found] ` <35FD53F367049845BC99AC72306C23D103E010D1827B@CNBJMBX05.corpusers.net>
2014-10-31 7:45 ` [RFC] arm:remove clear_thread_flag(TIF_UPROBE) Joe Perches
2014-10-31 7:51 ` Wang, Yalin
2014-10-31 7:58 ` Joe Perches
2014-10-31 7:59 ` Wang, Yalin
2014-11-13 23:53 ` [RFC V6 2/3] arm:add bitrev.h file to support rbit instruction Russell King - ARM Linux
2014-11-14 0:05 ` Joe Perches
2014-11-14 0:17 ` Russell King - ARM Linux
2014-11-14 0:45 ` Joe Perches
2014-11-14 1:18 ` Russell King - ARM Linux
2014-11-14 1:26 ` Joe Perches
2014-11-14 9:52 ` Russell King - ARM Linux
2014-11-14 6:37 ` Takashi Iwai
2014-11-14 6:55 ` Joe Perches
2014-11-14 7:03 ` Takashi Iwai
2014-11-14 2:01 ` Wang, Yalin
2014-11-14 9:58 ` Russell King - ARM Linux
2014-11-17 2:38 ` Wang, Yalin
2015-01-08 18:40 ` Russell King - ARM Linux
2015-01-09 2:16 ` Wang, Yalin
2015-01-09 11:10 ` Russell King - ARM Linux
2015-01-09 12:40 ` Wang, Yalin
2015-01-14 16:38 ` Russell King - ARM Linux
2015-01-16 1:42 ` Wang, Yalin
[not found] ` <35FD53F367049845BC99AC72306C23D103E010D18274@CNBJMBX05.corpusers.net>
2014-10-31 10:43 ` [RFC V6 3/3] arm64:add " Will Deacon
2014-11-03 2:17 ` Wang, Yalin
2014-11-03 8:47 ` Ard Biesheuvel
2014-11-03 9:50 ` Will Deacon
2014-11-04 1:45 ` Wang, Yalin
2014-10-31 2:03 ` [RFC V5 " Wang, Yalin
[not found] ` <35FD53F367049845BC99AC72306C23D103E010D18259@CNBJMBX05.corpusers.net>
2014-10-27 10:48 ` [RFC V3] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE " Will Deacon
2014-10-28 1:34 ` Wang, Yalin
2014-10-28 13:59 ` Will Deacon
2014-10-29 2:52 ` Wang, Yalin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414392371.8884.2.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox