From: iivanov@mm-sol•com (Ivan T. Ivanov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/7] pinctrl: pinconf-generic: Allow driver to specify DT params
Date: Wed, 19 Nov 2014 09:49:39 +0200 [thread overview]
Message-ID: <1416383379.30131.14.camel@mm-sol.com> (raw)
In-Reply-To: <995406b8e0244c63a3ef8e58314e81f6@BL2FFO11FD037.protection.gbl>
On Tue, 2014-11-18 at 09:25 -0800, S?ren Brinkmann wrote:
> On Tue, 2014-11-18 at 10:50AM +0200, Ivan T. Ivanov wrote:
> >
> > On Tue, 2014-11-11 at 15:53 +0100, Linus Walleij wrote:
> > > On Mon, Nov 3, 2014 at 8:05 PM, Soren Brinkmann
> > > brinkmann at xilinx.com> wrote:
> > >
> > > > Additionally to the generic DT parameters, allow drivers to
> > > > provide driver-specific DT parameters to be used with the
> > > > generic parser infrastructure.
> > > >
> > > > Signed-off-by: Soren Brinkmann brinkmann at xilinx.com>
> > >
> > > I like the looks of this, but the patch description is a bit
> > > terse. I'd like it to describe some of the refactorings being
> > > done
> > > to the intrinsics, because I have a hard time following the
> > > patch.
> > >
> > > First please rebase onto the "devel" branch in the pin control
> > > tree, and notice that drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> > > which is merged there is actually doing this already:
> > >
> > >
> > > for_each_child_of_node(np_config, np) {
> > > ret = pinconf_generic_dt_subnode_to_map(pctldev,
> > > np, map,
> > > &reserv,
> > > nmaps, type);
> > > if (ret)
> > > break;
> > >
> > > ret = pmic_gpio_dt_subnode_to_map(pctldev, np,
> > > map, &reserv,
> > > nmaps, type);
> > > if (ret)
> > > break;
> > > }
> > >
> > > So it should be patched to illustrate the point of this code.
> > >
> >
> > I like the idea, but have issues with implementations :-).
> >
> > It is supposed that additional parameters are not generic,
> > otherwise they will be part of enum pin_config_param, right?
> >
> > Probably it will be better if clients could pass array with
> > driver specific dt bindings to pinconf_generic_dt_node_to_map()?
>
> My idea was to hide that API from the driver. You just pass those
> parameters as part of the struct pctldev and the parser - whether
> this generic one or anything else - would do the right thing. I
> don't think calling the parser from the driver is the right approach.
Drivers already know about dt_node_to_map(). My proposal will make
drivers, which register non-standard bindings, little bit simpler.
With your approach probably we can remove dt_node_to_map() and
dt_free_map() callbacks?
Regards,
Ivan
next prev parent reply other threads:[~2014-11-19 7:49 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 19:05 [PATCH 0/7] Pinctrl support for Zynq Soren Brinkmann
2014-11-03 19:05 ` [PATCH 1/7] pinctrl: pinconf-generic: Declare dt_params/conf_items const Soren Brinkmann
2014-11-11 12:00 ` Linus Walleij
2014-11-03 19:05 ` [PATCH 2/7] pinctrl: pinconf-generic: Infer map type from DT property Soren Brinkmann
2014-11-05 13:56 ` Laurent Pinchart
2014-11-05 18:09 ` Sören Brinkmann
2014-11-05 18:17 ` Laurent Pinchart
2014-11-11 12:29 ` Linus Walleij
2014-11-12 18:43 ` Sören Brinkmann
2014-11-11 12:47 ` Linus Walleij
2014-11-12 18:46 ` Sören Brinkmann
2014-11-12 19:38 ` Sören Brinkmann
2014-11-03 19:05 ` [PATCH 3/7] pinctrl: pinconf-generic: Allow driver to specify DT params Soren Brinkmann
2014-11-03 19:12 ` Geert Uytterhoeven
2014-11-11 14:53 ` Linus Walleij
2014-11-18 8:50 ` Ivan T. Ivanov
2014-11-18 17:25 ` Sören Brinkmann
2014-11-19 7:49 ` Ivan T. Ivanov [this message]
2014-11-19 15:35 ` Sören Brinkmann
2014-11-20 8:06 ` Ivan T. Ivanov
2014-11-20 16:22 ` Sören Brinkmann
2014-11-21 7:35 ` Ivan T. Ivanov
2014-11-22 16:06 ` Sören Brinkmann
2014-11-24 8:52 ` Ivan T. Ivanov
2014-11-27 17:53 ` Sören Brinkmann
2014-11-03 19:05 ` [PATCH 4/7] pinctrl: zynq: Document DT binding Soren Brinkmann
2014-11-05 3:35 ` Andreas Färber
2014-11-05 17:07 ` Sören Brinkmann
2014-11-11 15:00 ` Linus Walleij
2014-11-12 18:53 ` Sören Brinkmann
2014-11-27 13:10 ` Linus Walleij
2014-11-03 19:05 ` [PATCH 5/7] pinctrl: Add driver for Zynq Soren Brinkmann
2014-11-05 3:24 ` Andreas Färber
2014-11-05 17:10 ` Sören Brinkmann
2014-11-05 5:12 ` Andreas Färber
2014-11-05 17:14 ` Sören Brinkmann
2014-11-03 19:05 ` [PATCH 6/7] ARM: zynq: Enable pinctrl Soren Brinkmann
2014-11-03 19:05 ` [PATCH 7/7] ARM: zynq: DT: Add pinctrl information Soren Brinkmann
2014-11-05 5:56 ` [PATCH 0/7] Pinctrl support for Zynq Andreas Färber
2014-11-05 17:03 ` Sören Brinkmann
2014-11-06 3:51 ` Andreas Färber
2014-11-06 4:13 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416383379.30131.14.camel@mm-sol.com \
--to=iivanov@mm-sol$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox