From: joe@perches•com (Joe Perches)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY
Date: Wed, 10 Dec 2014 22:12:02 -0800 [thread overview]
Message-ID: <1418278322.18092.30.camel@perches.com> (raw)
In-Reply-To: <5489338C.1030109@ti.com>
On Thu, 2014-12-11 at 11:32 +0530, Kishon Vijay Abraham I wrote:
> On Wednesday 10 December 2014 04:16 PM, Yunzhi Li wrote:
> > diff --git a/drivers/phy/phy-rockchip-usb.c b/drivers/phy/phy-rockchip-usb.c
[]
> > +/*
> > + * The higher 16-bit of this register is used for write protection
> > + * only if BIT(13 + 16) set to 1 the BIT(13) can be written.
> > + */
> > +#define SIDDQ_MSK BIT(13 + 16)
huh?
This #define looks _very_ odd.
Is this supposed to be a single bit 29 or
some range?
next prev parent reply other threads:[~2014-12-11 6:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 10:46 [PATCH v5 0/5] Patches to add support for Rockchip usb PHYs Yunzhi Li
2014-12-10 10:46 ` [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY Yunzhi Li
2014-12-11 6:02 ` Kishon Vijay Abraham I
2014-12-11 6:12 ` Joe Perches [this message]
2014-12-11 6:27 ` Kishon Vijay Abraham I
2014-12-11 6:37 ` Joe Perches
2014-12-11 6:52 ` Yunzhi Li
2014-12-11 7:06 ` Joe Perches
2014-12-11 7:16 ` Chris Zhong
2014-12-11 7:44 ` Yunzhi Li
2014-12-11 8:36 ` Kishon Vijay Abraham I
2014-12-10 10:46 ` [PATCH v5 4/5] ARM: dts: rockchip: add rk3288 usb PHY Yunzhi Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418278322.18092.30.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox