From: bhuvanchandra.dv@toradex•com (BhuvanChandra.DV)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 7/7] spi: spi-fsl-dspi: Add support for TCFQ transfer mode
Date: Thu, 29 Jan 2015 12:53:57 +0000 [thread overview]
Message-ID: <1422536382672.21760@toradex.com> (raw)
In-Reply-To: <20150129121320.GI21293@sirena.org.uk>
On 01/29/2015 05:43 PM, Mark Brown wrote:
> On Thu, Jan 29, 2015 at 11:58:25AM +0000, BhuvanChandra.DV wrote:
>
>> As far as i understood the major difference between the two modes are when
>> the interrupt to trigger, as EOQ mode will trigger the interrupt at end of
>> queue and TCF will trigger the interrupt at every frame transfer. Probably
>> mode selection shouldn't be a device tree property, but i don't see any
>> automatic way to choose between the modes.
>> Maybe a config would be more appropriate?
> Or if there's either no particular reason to choose one over the other
> or one is always better then just pick one in the driver and don't worry
> about implementing both.
Among the two, EOQ would be better since with TCF, interrupts are generated at
every frame transfer, which could be a problem at higher frequencies.
I think we can omit this patch then.
next prev parent reply other threads:[~2015-01-29 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 11:03 [PATCH 6/7] spi: spi-fsl-dspi: split the resuable code Bhuvanchandra DV
2015-01-27 11:03 ` [PATCH 7/7] spi: spi-fsl-dspi: Add support for TCFQ transfer mode Bhuvanchandra DV
2015-01-28 19:03 ` Mark Brown
2015-01-29 11:58 ` BhuvanChandra.DV
2015-01-29 12:13 ` Mark Brown
2015-01-29 12:53 ` BhuvanChandra.DV [this message]
2015-01-29 18:10 ` Stefan Agner
2015-01-30 12:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422536382672.21760@toradex.com \
--to=bhuvanchandra.dv@toradex$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox