From: ian.campbell@citrix•com (Ian Campbell)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] xen/arm: allow console=hvc0 to be omitted for guests
Date: Thu, 12 Feb 2015 04:54:33 +0000 [thread overview]
Message-ID: <1423716873.27551.30.camel@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1502120433040.29696@kaball.uk.xensource.com>
On Thu, 2015-02-12 at 04:35 +0000, Stefano Stabellini wrote:
> On Tue, 10 Feb 2015, Ian Campbell wrote:
> > On Tue, 2015-02-10 at 15:51 +0800, Ard Biesheuvel wrote:
> > > > FWIW on x86 this doesn't depend on console_set_on_cmdline, does it need
> > > > to here?
> > > >
> > >
> > > I didn't check the code, but it seems inappropriate to add a preferred
> > > console implicitly if the user has set 'console=' on the command line.
> >
> > I had been thinking that add_preferred_console would DTRT, but it seems
> > not. Seems strange that most calls to it do not check if the console is
> > already set, but it does seem like the right thing in this case.
> >
> > > > On x86 it does depend on !xen_initial_domain. I suppose on the principal
> > > > that a VT is normally available there. I suppose that doesn't apply to
> > > > ARM so much, although it could.
> > > >
> > >
> > > OK, I got confused by the xen_guest_init(). So do you mean if if
> > > (!xen_initial_domain) should be added?
> >
> > (dom0 is "Just A Guest" too ;-))
> >
> > Adding it would be consistent with x86, I'm not precisely sure if that
> > is important or desirable in this case. I'd be inclined to start with
> > the if there.
>
> The reasoning is that dom0 command line arguments come from its old
> native grub stanza, therefore the console parameter is incorrect, right?
> As opposed to regular domUs, that being freshly installed, are supposed
> to have the correct console parameter?
Other way around I think, dom0 has the correct stuff from grub.cfg
whereas the guest may not.
next prev parent reply other threads:[~2015-02-12 4:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 13:58 [PATCH] xen/arm: allow console=hvc0 to be omitted for guests Ard Biesheuvel
2015-02-10 7:00 ` Stefano Stabellini
2015-02-10 7:26 ` Ian Campbell
2015-02-10 7:51 ` Ard Biesheuvel
2015-02-10 8:59 ` Ian Campbell
2015-02-12 4:35 ` Stefano Stabellini
2015-02-12 4:52 ` Stefano Stabellini
2015-02-12 4:54 ` Ian Campbell [this message]
2015-02-12 5:20 ` Julien Grall
2015-02-12 6:12 ` Stefano Stabellini
2015-02-10 7:36 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423716873.27551.30.camel@citrix.com \
--to=ian.campbell@citrix$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox