public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: iivanov@mm-sol•com (Ivan T. Ivanov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 0/3] Add initial DT support for Qualcomm SPMI PMIC devices
Date: Thu, 26 Feb 2015 18:25:57 +0200	[thread overview]
Message-ID: <1424967957.2340.30.camel@mm-sol.com> (raw)
In-Reply-To: <54E6848C.1090405@codeaurora.org>


Hi Stephan, 

Sorry for delayed answer.

On Thu, 2015-02-19 at 16:49 -0800, Stephen Boyd wrote:
> On 02/03/15 04:17, Ivan T. Ivanov wrote:
> > Following set of patches add initial DT support for PMIC devices
> > found on recent Quqalcomm chipsets. Details for SPMI bus and PMIC arbiter
> > could be found here [1].
> 
> Can you please put the specific compatible strings for the pmic model
> into the nodes in addition to the generic "qcom,spmi-pmic"? We may want
> to have regmap config tables in the future that describe the
> cache/read/write abilities of the regsiters. If all we have is the
> generic binding then we don't have a way to populate these tables.
> Unless the plan there is to use the revid registers?
> 

I would really like that we can use "revid" registers, but I don't know... 

>From what I can see usually in one physical PMIC chip they
are 2 USID devices.

I can successfully discover following USID's on APQ8074 boards:

pmic-spmi 0-00: qcom,pm8941-v1.0 detected
pmic-spmi 0-01: qcom,pm8941-v1.0 detected
pmic-spmi 0-04: qcom,pm8841-v0.0 detected
pmic-spmi 0-05: qcom,pm8841-v0.0 detected

Unfortunately on PM8916 only one device is detected, with USID 0.
But they should be two, judging by downstream DTS files, right?

pmic-spmi 0-00: qcom,pm8916-v0.0 detected 
pmic-spmi 0-01: unknown device

For communication with PM8916 I am using recent patches from Gilad [1].
Maybe there are still some issues with these patches, which can cause
this behavior or PM8916 just didn't have these registers for USID 1?

Regards,
Ivan 

[1] https://lkml.org/lkml/2015/2/19/453

  reply	other threads:[~2015-02-26 16:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03 12:17 [PATCH 0/3] Add initial DT support for Qualcomm SPMI PMIC devices Ivan T. Ivanov
2015-02-03 12:17 ` [PATCH 1/3] ARM: dts: qcom: Add SPMI PMIC Arbiter nodes for APQ8084 and MSM8974 Ivan T. Ivanov
2018-08-31 22:46   ` Frank Rowand
2018-08-31 22:50     ` Frank Rowand
2018-08-31 23:01     ` Bjorn Andersson
2018-09-01  0:05       ` Frank Rowand
2015-02-03 12:17 ` [PATCH 2/3] ARM: dts: qcom: Add 8x74 chipset SPMI PMIC's nodes Ivan T. Ivanov
2015-02-03 12:18 ` [PATCH 3/3] ARM: dts: qcom: Add APQ8084 " Ivan T. Ivanov
2015-02-03 20:38 ` [PATCH 0/3] Add initial DT support for Qualcomm SPMI PMIC devices Bjorn Andersson
2015-02-10  7:17   ` Ivan T. Ivanov
2015-02-10 21:58 ` Andy Gross
2015-02-20  0:49 ` Stephen Boyd
2015-02-26 16:25   ` Ivan T. Ivanov [this message]
2015-03-03  8:19     ` Stephen Boyd
2015-03-04 10:31       ` Ivan T. Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424967957.2340.30.camel@mm-sol.com \
    --to=iivanov@mm-sol$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox