From: sboyd@codeaurora•org (Stephen Boyd)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/6] regulator: core: Don't spew backtraces on duplicate sysfs
Date: Mon, 1 Jun 2015 18:47:54 -0700 [thread overview]
Message-ID: <1433209679-31389-2-git-send-email-sboyd@codeaurora.org> (raw)
In-Reply-To: <1433209679-31389-1-git-send-email-sboyd@codeaurora.org>
We don't consider a failure to add the sysfs node as a problem,
so use sysfs_create_link_nowarn() so that we don't print a
backtrace when duplicated files exist. Also, downgrade the printk
message to a debug statement so that we're quiet here. This
allows multiple drivers to request a CPU's regulator so that
CPUfreq and AVSish drivers can coexist.
Signed-off-by: Stephen Boyd <sboyd@codeaurora•org>
---
drivers/regulator/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 443eaab933fc..f6989485c382 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1192,10 +1192,10 @@ static struct regulator *create_regulator(struct regulator_dev *rdev,
if (regulator->supply_name == NULL)
goto overflow_err;
- err = sysfs_create_link(&rdev->dev.kobj, &dev->kobj,
+ err = sysfs_create_link_nowarn(&rdev->dev.kobj, &dev->kobj,
buf);
if (err) {
- rdev_warn(rdev, "could not add device link %s err %d\n",
+ rdev_dbg(rdev, "could not add device link %s err %d\n",
dev->kobj.name, err);
/* non-fatal */
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-06-02 1:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 1:47 [PATCH 0/6] Support CPR on MSM8916 Stephen Boyd
2015-06-02 1:47 ` Stephen Boyd [this message]
2015-06-03 12:20 ` [PATCH 1/6] regulator: core: Don't spew backtraces on duplicate sysfs Mark Brown
2015-06-02 1:47 ` [PATCH 2/6] regulator: core: Print at debug level on debugfs creation failure Stephen Boyd
2015-06-03 18:39 ` Mark Brown
2015-06-02 1:47 ` [PATCH 3/6] PM / OPP: Support adjusting OPP voltages at runtime Stephen Boyd
2015-06-02 4:50 ` Viresh Kumar
2015-06-02 19:54 ` Stephen Boyd
2015-06-02 1:47 ` [RFC/PATCH 4/6] OPP: Allow notifiers to call dev_pm_opp_get_{voltage, freq} RCU-free Stephen Boyd
2015-06-02 3:30 ` [RFC/PATCH 4/6] OPP: Allow notifiers to call dev_pm_opp_get_{voltage,freq} RCU-free Krzysztof Kozlowski
2015-06-03 22:43 ` [RFC/PATCH 4/6] OPP: Allow notifiers to call dev_pm_opp_get_{voltage, freq} RCU-free Stephen Boyd
2015-06-02 1:47 ` [PATCH 5/6] cpufreq-dt: Handle OPP voltage adjust events Stephen Boyd
2015-06-02 1:47 ` [PATCH 6/6] power: avs: Add support for CPR (Core Power Reduction) Stephen Boyd
2015-06-02 10:53 ` [PATCH 0/6] Support CPR on MSM8916 Mark Brown
2015-06-02 17:56 ` Stephen Boyd
2015-06-02 18:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433209679-31389-2-git-send-email-sboyd@codeaurora.org \
--to=sboyd@codeaurora$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox