From: iivanov@mm-sol•com (Ivan T. Ivanov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V4 2/7] qup: i2c: factor out common code for reuse
Date: Mon, 20 Jul 2015 11:25:00 +0300 [thread overview]
Message-ID: <1437380700.6267.1.camel@mm-sol.com> (raw)
In-Reply-To: <1436412350-19519-3-git-send-email-sricharan@codeaurora.org>
Hi Sricharan,
On Thu, 2015-07-09 at 08:55 +0530, Sricharan R wrote:
>
> static int qup_i2c_read_one(struct qup_i2c_dev *qup, struct i2c_msg *msg)
> {
> - unsigned long left;
> - int ret;
> + int ret = 0;
>
> - qup->msg = msg;
> - qup->pos = 0;
> + /*
> + * The QUP block will issue a NACK and STOP on the bus when reaching
> + * the end of the read, the length of the read is specified as one byte
> + * which limits the possible read to 256 (QUP_READ_LIMIT) bytes.
> + */
> + if (msg->len > QUP_READ_LIMIT) {
> + dev_err(qup->dev, "HW not capable of reads over %d bytes\n",
> + QUP_READ_LIMIT);
> + return -EINVAL;
> + }
>
This should be removed. Please see qup_i2c_quirks.
Regards,
Ivan
next prev parent reply other threads:[~2015-07-20 8:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 3:25 [PATCH V4 0/7] i2c: qup: Add support for v2 tags and bam dma Sricharan R
2015-07-09 3:25 ` [PATCH V4 1/7] i2c: qup: Change qup_wait_writeready function to use for all timeouts Sricharan R
2015-07-09 3:25 ` [PATCH V4 2/7] qup: i2c: factor out common code for reuse Sricharan R
2015-07-20 8:25 ` Ivan T. Ivanov [this message]
2015-07-21 6:54 ` Sricharan
2015-07-09 3:25 ` [PATCH V4 3/7] i2c: qup: Add V2 tags support Sricharan R
2015-07-20 9:44 ` Ivan T. Ivanov
2015-07-21 7:11 ` Sricharan
2015-07-09 3:25 ` [PATCH V4 4/7] i2c: qup: Transfer each i2c_msg in i2c_msgs without a stop bit Sricharan R
2015-07-20 11:22 ` Ivan T. Ivanov
2015-07-21 8:09 ` Sricharan
2015-07-09 3:25 ` [PATCH V4 5/7] i2c: qup: Add bam dma capabilities Sricharan R
2015-07-20 14:46 ` Ivan T. Ivanov
2015-07-21 11:10 ` Sricharan
2015-07-09 3:25 ` [PATCH V4 6/7] dts: msm8974: Add blsp2_bam dma node Sricharan R
2015-07-09 3:25 ` [PATCH V4 7/7] dts: msm8974: Add dma channels for blsp2_i2c1 node Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437380700.6267.1.camel@mm-sol.com \
--to=iivanov@mm-sol$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox