From: ian.campbell@citrix•com (Ian Campbell)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/8] arm/xen: Remove helpers which are PV specific
Date: Fri, 31 Jul 2015 11:55:42 +0100 [thread overview]
Message-ID: <1438340142.30740.57.camel@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1507311142580.11337@kaball.uk.xensource.com>
On Fri, 2015-07-31 at 11:44 +0100, Stefano Stabellini wrote:
> On Tue, 28 Jul 2015, Julien Grall wrote:
> > ARM guests are assimilated to HVM guest on ARM. The current
> > implementation is assuming a 1:1 mapping which is only true for DOM0
> > and
> > may not be at all in the future.
> >
> > Furthermore, all the helpers but arbitrary_virt_to_machine are used in
> > x86 specific code (or only compiled for).
> >
> > The helper arbitrary_virt_to_machine is only used in PV specific code.
> > Therefore we should never call the function.
> >
> > Add a BUG() in this helper and drop all the others.
> >
> > Signed-off-by: Julien Grall <julien.grall@citrix•com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu•citrix.com>
> > Cc: Russell King <linux@arm•linux.org.uk>
> > Cc: linux-arm-kernel at lists.infradead.org
> > ---
> > arch/arm/include/asm/xen/page.h | 16 ++--------------
> > 1 file changed, 2 insertions(+), 14 deletions(-)
> >
> > diff --git a/arch/arm/include/asm/xen/page.h
> > b/arch/arm/include/asm/xen/page.h
> > index 1bee8ca..c2e9dcd 100644
> > --- a/arch/arm/include/asm/xen/page.h
> > +++ b/arch/arm/include/asm/xen/page.h
> > @@ -54,26 +54,14 @@ static inline unsigned long mfn_to_pfn(unsigned
> > long mfn)
> >
> > #define mfn_to_local_pfn(mfn) mfn_to_pfn(mfn)
> >
> > -static inline xmaddr_t phys_to_machine(xpaddr_t phys)
> > -{
> > - unsigned offset = phys.paddr & ~PAGE_MASK;
> > - return XMADDR(PFN_PHYS(pfn_to_mfn(PFN_DOWN(phys.paddr))) |
> > offset);
> > -}
> > -
> > -static inline xpaddr_t machine_to_phys(xmaddr_t machine)
> > -{
> > - unsigned offset = machine.maddr & ~PAGE_MASK;
> > - return XPADDR(PFN_PHYS(mfn_to_pfn(PFN_DOWN(machine.maddr))) |
> > offset);
> > -}
> > /* VIRT <-> MACHINE conversion */
> > -#define virt_to_machine(v) (phys_to_machine(XPADDR(__pa(v))))
> > #define virt_to_mfn(v) (pfn_to_mfn(virt_to_pfn(v)))
> > #define mfn_to_virt(m) (__va(mfn_to_pfn(m) << PAGE_SHIFT))
> >
> > +/* Only used in PV code. However ARM guest is always assimilated as
> > HVM. */
> ^ "However" doesn't make sense here from an
> english grammer point of view.
"English grammar" :-P
Sorry. What I really meant to say was that "assimilated" doesn't make sense
in this context either. I think maybe what was meant is "ARM guests are
always HVM".
Ian.
next prev parent reply other threads:[~2015-07-31 10:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 15:02 [PATCH 0/8] Use correctly the Xen memory terminologies in Linux Julien Grall
2015-07-28 15:02 ` [PATCH 1/8] arm/xen: Remove helpers which are PV specific Julien Grall
2015-07-31 10:44 ` Stefano Stabellini
2015-07-31 10:55 ` Ian Campbell [this message]
2015-08-04 16:36 ` [Xen-devel] " Julien Grall
2015-07-28 15:02 ` [PATCH 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address Julien Grall
2015-07-28 15:52 ` [Xen-devel] " David Vrabel
2015-07-28 16:06 ` Julien Grall
2015-07-31 10:54 ` Stefano Stabellini
2015-07-28 15:02 ` [PATCH 3/8] arm/xen: implement correctly pfn_to_mfn Julien Grall
2015-07-28 15:02 ` [PATCH 4/8] xen: Use the correctly the Xen memory terminologies Julien Grall
2015-07-28 17:16 ` [Xen-devel] " David Vrabel
2015-07-29 11:06 ` Julien Grall
2015-07-28 19:12 ` Boris Ostrovsky
2015-07-29 11:25 ` Julien Grall
2015-07-29 14:14 ` Boris Ostrovsky
2015-07-29 14:23 ` Julien Grall
2015-07-29 14:51 ` Boris Ostrovsky
2015-07-28 19:39 ` [Xen-devel] " Chris (Christopher) Brand
2015-07-29 11:27 ` Julien Grall
2015-07-29 10:13 ` Wei Liu
2015-07-29 11:35 ` [Xen-devel] " Julien Grall
2015-07-29 11:38 ` David Vrabel
2015-07-29 11:39 ` Wei Liu
2015-07-31 11:02 ` Stefano Stabellini
2015-07-28 15:02 ` [PATCH 8/8] xen/privcmd: Further s/MFN/GFN/ clean-up Julien Grall
2015-07-28 17:19 ` [Xen-devel] " David Vrabel
2015-07-28 21:06 ` [PATCH 0/8] Use correctly the Xen memory terminologies in Linux H. Peter Anvin
2015-07-28 21:12 ` [Xen-devel] " Andrew Cooper
2015-07-29 11:02 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438340142.30740.57.camel@citrix.com \
--to=ian.campbell@citrix$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox