From: pawel.moll@arm•com (Pawel Moll)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] clk: versatile: Switch to assigned clock parents
Date: Mon, 03 Aug 2015 15:01:20 +0100 [thread overview]
Message-ID: <1438610480.2142.14.camel@arm.com> (raw)
In-Reply-To: <1438386285-5070-2-git-send-email-sboyd@codeaurora.org>
On Sat, 2015-08-01 at 00:44 +0100, Stephen Boyd wrote:
> @@ -179,6 +124,15 @@ static void __init clk_sp810_of_setup(struct device_node *node)
> sp810->timerclken[i].channel = i;
> sp810->timerclken[i].hw.init = &init;
>
> + /*
> + * If DT isn't setting the parent, force it to be
> + * the 1 MHz clock without going through the framework.
> + * We do this before clk_register() so that it can determine
> + * the parent and setup the tree properly.
> + */
> + if (deprecated)
> + init.ops->set_parent(&sp810->timerclken[i].hw, 1);
> +
> sp810->timerclken[i].clk = clk_register(NULL,
> &sp810->timerclken[i].hw);
> WARN_ON(IS_ERR(sp810->timerclken[i].clk));
So that's one thing I've got a (small) problem here...
The above change assumes that SP810 always have 32kHz clock on input 0
and 1MHz clock on input 1. Yes, this is how it made on VExpress, but it
doesn't have to be the case. The magic picking up the faster clock was
added to handle all possible cases.
The bottom line is: if all we care is VExpress than it works, but it's
still a hack. Personally I don't like it, however I won't nak the patch
because of this.
Pawel
next prev parent reply other threads:[~2015-08-03 14:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <55BBB2FC.9030102@codeaurora.org>
2015-07-31 23:44 ` [PATCH 0/3] Move clk-sp810 to assigned clock parents Stephen Boyd
2015-07-31 23:44 ` [PATCH 1/3] clk: versatile: Switch " Stephen Boyd
2015-08-03 14:01 ` Pawel Moll [this message]
2015-08-03 17:55 ` Stephen Boyd
2015-08-05 10:29 ` Pawel Moll
2015-08-05 17:56 ` Stephen Boyd
2015-08-06 15:05 ` Pawel Moll
2015-08-07 22:28 ` Stephen Boyd
2015-07-31 23:44 ` [PATCH 2/3] ARM: dts: vexpress: Use assigned-clock-parents for sp810 Stephen Boyd
2015-07-31 23:44 ` [PATCH 3/3] ARM64: " Stephen Boyd
2015-08-03 10:18 ` [PATCH 0/3] Move clk-sp810 to assigned clock parents Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438610480.2142.14.camel@arm.com \
--to=pawel.moll@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox