public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: joe@perches•com (Joe Perches)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] ARM: uniphier: add outer cache support
Date: Sun, 23 Aug 2015 19:29:19 -0700	[thread overview]
Message-ID: <1440383359.2670.15.camel@perches.com> (raw)
In-Reply-To: <1440382692-3855-2-git-send-email-yamada.masahiro@socionext.com>

On Mon, 2015-08-24 at 11:18 +0900, Masahiro Yamada wrote:
> This commit adds support for UniPhier outer cache controller.
> All the UniPhier SoCs are equipped with the L2 cache, while the L3
> cache is currently only integrated on PH1-Pro5 SoC.

style trivia:

You might add and use
	#define pr_fmt(fmt) "uniphier: " fmt
before any other #include so all of the pr_<level>
uses are automatically prefixed.

> diff --git a/arch/arm/mm/cache-uniphier.c b/arch/arm/mm/cache-uniphier.c
[]
> +static int __init __uniphier_cache_init(void)
> +{
[]
> +	if (uniphier_outer_levels == 0) {
> +		ret = ret ?: -ENODEV;
> +		pr_err("uniphier: failed to initialize outer cache\n");

So this becomes:
		pr_err("failed to initialize outer cache\n");

> +int __init uniphier_cache_init(void)
> +{
[]
> +	pr_info("uniphier: enabled outer cache (%s)\n",
> +		uniphier_outer_levels >= 2 ? "L2 and L3" : "L2");

	pr_info("enabled outer cache (%s)\n",
		uniphier_outer_levels >= 2 ? "L2 and L3" : "L2");

etc...

  reply	other threads:[~2015-08-24  2:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24  2:18 [PATCH 0/3] ARM: uniphier: add outer cache support and rework SMP operations Masahiro Yamada
2015-08-24  2:18 ` [PATCH 1/3] ARM: uniphier: add outer cache support Masahiro Yamada
2015-08-24  2:29   ` Joe Perches [this message]
2015-08-24  2:58     ` Masahiro Yamada
2015-08-24 19:59   ` Arnd Bergmann
2015-08-26  1:38     ` Masahiro Yamada
2015-08-26 12:52       ` Arnd Bergmann
2015-08-28  8:59         ` Masahiro Yamada
2015-08-28  9:44         ` Russell King - ARM Linux
2015-08-26 13:39   ` Linus Walleij
2015-08-28 10:24     ` Masahiro Yamada
2015-09-08 13:09       ` Linus Walleij
2015-09-09  0:06         ` Rob Herring
2015-08-24  2:18 ` [PATCH 2/3] ARM: uniphier: rework SMP operations to use trampoline code Masahiro Yamada
2015-08-24  2:18 ` [PATCH 3/3] ARM: dts: uniphier: add outer cache controller nodes Masahiro Yamada
2015-08-24 21:47 ` [PATCH 0/3] ARM: uniphier: add outer cache support and rework SMP operations Olof Johansson
2015-08-25  1:50   ` Masahiro Yamada
2015-08-25  3:05     ` Olof Johansson
2015-08-25  3:19       ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440383359.2670.15.camel@perches.com \
    --to=joe@perches$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox