From: sboyd@codeaurora•org (Stephen Boyd)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 3/4] soc: qcom: smd: Use __ioread32_copy() instead of open-coding it
Date: Fri, 23 Oct 2015 13:01:51 -0700 [thread overview]
Message-ID: <1445630512-10888-4-git-send-email-sboyd@codeaurora.org> (raw)
In-Reply-To: <1445630512-10888-1-git-send-email-sboyd@codeaurora.org>
Now that we have a generic library function for this, replace the
open-coded instance.
Cc: Bjorn Andersson <bjorn.andersson@sonymobile•com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora•org>
---
drivers/soc/qcom/smd.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c
index 86b598cff91a..498fd0581a45 100644
--- a/drivers/soc/qcom/smd.c
+++ b/drivers/soc/qcom/smd.c
@@ -434,20 +434,15 @@ static void smd_copy_to_fifo(void __iomem *dst,
/*
* Copy count bytes of data using 32bit accesses, if that is required.
*/
-static void smd_copy_from_fifo(void *_dst,
- const void __iomem *_src,
+static void smd_copy_from_fifo(void *dst,
+ const void __iomem *src,
size_t count,
bool word_aligned)
{
- u32 *dst = (u32 *)_dst;
- u32 *src = (u32 *)_src;
-
if (word_aligned) {
- count /= sizeof(u32);
- while (count--)
- *dst++ = __raw_readl(src++);
+ __ioread32_copy(dst, src, count / sizeof(u32));
} else {
- memcpy_fromio(_dst, _src, count);
+ memcpy_fromio(dst, src, count);
}
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-10-23 20:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 20:01 [PATCH v3 0/4] Add __ioread32_copy() and use it Stephen Boyd
2015-10-23 20:01 ` [PATCH v3 1/4] frv: io: Accept const void pointers for read{b,w,l}() Stephen Boyd
2015-10-23 20:01 ` [PATCH v3 2/4] lib: iomap_copy: Add __ioread32_copy() Stephen Boyd
2015-10-23 20:01 ` Stephen Boyd [this message]
2015-10-23 20:22 ` [PATCH v3 3/4] soc: qcom: smd: Use __ioread32_copy() instead of open-coding it Bjorn Andersson
2015-10-26 2:00 ` Andy Gross
2015-10-23 20:01 ` [PATCH v3 4/4] FIRMWARE: bcm47xx_nvram: Use __ioread32_copy() instead of open-coding Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445630512-10888-4-git-send-email-sboyd@codeaurora.org \
--to=sboyd@codeaurora$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox