From: marcel.ziswiler@toradex•com (Marcel Ziswiler)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM
Date: Fri, 8 Jan 2016 10:59:20 +0000 [thread overview]
Message-ID: <1452250758.3357.25.camel@toradex.com> (raw)
In-Reply-To: <20160108084247.GB27359@ibawizard.net>
On Fri, 2016-01-08 at 09:42 +0100, Petr ?tetiar wrote:
> Marcel Ziswiler <marcel.ziswiler@toradex•com> [2016-01-06 09:15:18]:
>
> > > > <&pinctrl_regulator_usbotg_pwr>;
> > > > + regulator-name = "usb_otg_vbus";
> > > > + regulator-min-microvolt = <5000000>;
> > > > + regulator-max-microvolt = <5000000>;
> > > > + gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
> > > > + enable-active-high;
> > > > + status = "disabled";
> > > > + };
> > >
> > > I'm not sure, but it seems to me, that we should move this
> > > regulator into
> > > the carrier board DTS. On our custom carrier board we've this
> > > regulator
> > > always on and we use this GPIO for heartbeat LED, so I've this in
> > > our
> > > carrier board DTS[2]:
> >
> > Yes, you are absolutely right and e.g. on Apalis T30 [1] that is
> > exactly how
> > we did it.
>
> And what about usdhc? It leads to the same overrides in the carrier
> board
> file:
>
> &iomuxc {
> usdhc {
> /* GPIO4_IO20 is LVDS */
> pinctrl_mmc_cd: gpio_mmc_cd {
> };
>
> /* Used as misc GPIOs */
> pinctrl_usdhc1: usdhc1grp {
> };
> };
> };
Yes, the same applies here.
> > > > +/* PAD Ctrl values for common settings */
> > > > +/*
> > > > + * (PAD_CTL_HYS | PAD_CTL_PUS_100K_UP | PAD_CTL_PUE |
> > > > PAD_CTL_PKE
> > > > >
> > > > + *??PAD_CTL_SPEED_MED | PAD_CTL_DSE_40ohm)
> > > > + */
> > > > +#define PAD_CTRL_HYS_PU 0x1b0b0
> > >
> > > This was requested to be reworked. I've simply replaced all the
> > > macros with
> > > hex values.
> >
> > I don't think the reviewers really concluded on the action to be
> > taken
> > on here and just using hex values is probably the most stupid
> > solution.
>
> It's simple, if you just leave it as it is, then it will never get
> merged.
> That's how kernel development works :)
Thanks but I don't think you need to explain us how any of this works
(;-p).
> We've at least two options here:
>
> 1. Follow the old path and just convert those macros to hex values
Yes, stupid.
> 2. Rework it - move those macros to some header file etc.
As mentioned before I don't think any agreement has been reached.
> -- ynezz
Cheers
Marcel
next prev parent reply other threads:[~2016-01-08 10:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 16:39 [PATCH v2 0/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM/Ixora carrier board Marcel Ziswiler
2016-01-05 16:39 ` [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM Marcel Ziswiler
2016-01-06 8:03 ` Petr Štetiar
2016-01-06 9:15 ` Marcel Ziswiler
2016-01-08 8:42 ` Petr Štetiar
2016-01-08 10:59 ` Marcel Ziswiler [this message]
2016-01-07 6:29 ` Stefan Agner
2016-01-08 8:28 ` Marcel Ziswiler
2016-01-08 8:57 ` Petr Štetiar
2016-01-08 10:59 ` Marcel Ziswiler
2016-01-05 16:39 ` [PATCH v2 2/2] ARM: dts: imx6: Add support for Toradex Ixora carrier board Marcel Ziswiler
2016-01-07 6:38 ` Stefan Agner
2016-01-08 8:29 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452250758.3357.25.camel@toradex.com \
--to=marcel.ziswiler@toradex$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox