From: joe@perches•com (Joe Perches)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers
Date: Sun, 10 Jan 2016 07:07:05 -0800 [thread overview]
Message-ID: <1452438425.7773.21.camel@perches.com> (raw)
In-Reply-To: <1452427000-4520-2-git-send-email-mst@redhat.com>
On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote:
> SMP-only barriers were missing in checkpatch.pl
>
> Refactor code slightly to make adding more variants easier.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -5116,7 +5116,25 @@ sub process {
> ? }
> ? }
> ?# check for memory barriers without a comment.
> - if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
> +
> + my $barriers = qr{
> + mb|
> + rmb|
> + wmb|
> + read_barrier_depends
> + }x;
> + my $smp_barriers = qr{
> + store_release|
> + load_acquire|
> + store_mb|
> + ($barriers)
> + }x;
If I use a variable called $smp_barriers, I'd expect
it to actually be the smp_barriers, not to have to
prefix it with smp_ before using it.
my $smp_barriers = qr{
smp_store_release|
smp_load_acquire|
smp_store_mb|
smp_read_barrier_depends
}x;
or
my $smp_barriers = qr{
smp_(?:store_release|load_acquire|store_mb|read_barrier_depends)
}x;
?
> + my $all_barriers = qr{
> + $barriers|
> + smp_($smp_barriers)
> + }x;
And this shouldn't have a capture group.
my $all_barriers = qr{
$barriers|
$smp_barriers
}x;
> +
> + if ($line =~ /\b($all_barriers)\s*\(/) {
This doesn't need the capture group either (?:all_barriers)
> ? if (!ctx_has_comment($first_line, $linenr))
> {
> ? WARN("MEMORY_BARRIER",
> ? ?????"memory barrier without
> comment\n" . $herecurr);
next prev parent reply other threads:[~2016-01-10 15:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 11:56 [PATCH v2 0/3] checkpatch: handling of memory barriers Michael S. Tsirkin
2016-01-10 11:56 ` [PATCH v2 1/3] checkpatch.pl: add missing " Michael S. Tsirkin
2016-01-10 15:07 ` Joe Perches [this message]
2016-01-10 15:17 ` Joe Perches
2016-01-10 19:29 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 11:57 ` [PATCH v2 2/3] checkpatch: check for __smp outside barrier.h Michael S. Tsirkin
2016-01-10 15:08 ` Joe Perches
2016-01-10 11:57 ` [PATCH v2 3/3] checkpatch: add virt barriers Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452438425.7773.21.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox