From: pawel.moll@arm•com (Pawel Moll)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] bus: arm-ccn: Fix cpu notifier priority
Date: Thu, 10 Mar 2016 14:56:46 +0000 [thread overview]
Message-ID: <1457621806.22102.142.camel@arm.com> (raw)
In-Reply-To: <20160310143455.GA9998@hardcore>
On Thu, 2016-03-10 at 15:34 +0100, Jan Glauber wrote:
> On Wed, Mar 09, 2016 at 08:40:45AM +0000, Pawel Moll wrote:
> > On Tue, 2016-03-08 at 13:14 +0100, Jan Glauber wrote:
> > > Fix cpu priority of notifier block that was erroneously set to
> > > return value of next statement.
> > >
> > > Signed-off-by: Jan Glauber <jglauber@cavium•com>
> > > ---
> > > drivers/bus/arm-ccn.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/bus/arm-ccn.c b/drivers/bus/arm-ccn.c
> > > index 7082c72..d4a939e 100644
> > > --- a/drivers/bus/arm-ccn.c
> > > +++ b/drivers/bus/arm-ccn.c
> > > @@ -1271,7 +1271,7 @@ static int arm_ccn_pmu_init(struct arm_ccn
> > > *ccn)
> > > * picked to have a chance to migrate events before perf
> > > is
> > > notified.
> > > */
> > > ccn->dt.cpu_nb.notifier_call = arm_ccn_pmu_cpu_notifier;
> > > - ccn->dt.cpu_nb.priority = CPU_PRI_PERF + 1,
> > > + ccn->dt.cpu_nb.priority = CPU_PRI_PERF + 1;
> > > err = register_cpu_notifier(&ccn->dt.cpu_nb);
> > > if (err)
> > > goto error_cpu_notifier;
> >
> > Damn, of course! I have never made (or heard about) such a typo
> > before
> > - I wish the compiler warned about it :-(
>
> actually my patch description is wrong. The compiler evaluates both
> statements but does _not_ overwrite the value of the first statement
> (would require parenthesis to do so).
I must admit I looked at the code change rather than at the
description, but thinking about it now, comma has the lowest
precedence, so the assignments will win. Still, with gcc 6 now warning
about suspicious indentations, my wish still stays a wish ;-)
> So it is just a cosmetical change, feel free to drop it.
Oh no, it's still a bug (only maybe not a "stable-class" one). And one
I'll remember :-)
Thanks!
Pawel
prev parent reply other threads:[~2016-03-10 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 12:14 [PATCH] bus: arm-ccn: Fix cpu notifier priority Jan Glauber
2016-03-09 8:40 ` Pawel Moll
2016-03-09 14:24 ` Jan Glauber
2016-03-10 14:34 ` Jan Glauber
2016-03-10 14:56 ` Pawel Moll [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457621806.22102.142.camel@arm.com \
--to=pawel.moll@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox