From: plaes@plaes•org (Priit Laes)
To: linux-arm-kernel@lists•infradead.org
Subject: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property
Date: Wed, 29 Jun 2016 22:54:38 +0300 [thread overview]
Message-ID: <1467230078.2598.2.camel@plaes.org> (raw)
In-Reply-To: <6402170.5s0abZDqlD@wuerfel>
On Wed, 2016-06-29 at 21:33 +0200, Arnd Bergmann wrote:
> On Wednesday, June 29, 2016 8:51:44 PM CEST Arend Van Spriel wrote:
> > > Typical wifi devices will have some sort of non volatile storage
> > > on board to not only store the ethernet(mac) address, but also
> > > to contain e.g. info about the antenna gain so that the firmware
> > > and/or the driver can take the antenna gain into account and
> > > ensure
> > > that they never exceed the maximum allowed broadcast strength.
> > >
> > > However on some embedded devices there is no non-volatile storage
> > > for the wifi (for cost reasons) and instead this configuration
> > > info
> > > (which is board / pcb specific) is loaded in the form of a
> > > file which contains the contents which would normally be in the
> > > non-volatile storage.
> > >
> > > Since we are dealing with a per-board config-file here, which is
> > > loaded from the os filesystem we really need to specify a
> > > basename
> > > here as the list of possible boards is endless, so we cannot
> > > have a lookup table in the driver.
> >
> > As Jonas mentioned the general principle of device tree is to be
> > agnostic with regards to OS and/or driver as you undoubtedly know.
> > His
> > proposal seems like a usable solution for your problem while
> > complying
> > to the device tree principle. So instead of overriding the default
> > brcmfmac should modify it when dt specifies the "module" property,
> > ie:
> >
> > no "module" in DT:??????nvram filename = brcm/brcmfmac43362-
> > sdio.txt
> > "module=ap6210" in DT:??nvram filename = brcm/brcmfmac43362-
> > ap6210.txt
> >
> > By the way, the example in the bindings file does not seem to
> > specify a
> > basename, but path+basename+fileext.
>
> What is the size of this nvram file? As it's board specific, I wonder
> if we can simply include it inside of the DT verbatim. I remember
> doing that (in the pre-dtb days, on real open firmware) for the
> "spidernet"
> ethernet driver.
It contains a bit too much info:
This is what CubieTruck requires:
http://dl.cubieboard.org/public/Cubieboard/benn/firmware/ap6210/nvram_a
p6210.txt
next prev parent reply other threads:[~2016-06-29 19:54 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 14:04 [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property Hans de Goede
2016-06-29 14:04 ` [PATCH 2/4] ARM: dts: sun7i-a20-cubietruck: Set brcm,nvram_file_name Hans de Goede
2016-06-29 17:01 ` [PATCH 2/4] ARM: dts: sun7i-a20-cubietruck: Set brcm, nvram_file_name Kalle Valo
2016-06-29 18:01 ` [linux-sunxi] Re: [PATCH 2/4] ARM: dts: sun7i-a20-cubietruck: Set brcm,nvram_file_name Hans de Goede
2016-06-29 14:04 ` [PATCH 3/4] ARM: dts: sun7i-a20-wits-pro-a20-dkt: Set brcm, nvram_file_name Hans de Goede
2016-06-29 14:04 ` [PATCH 4/4] ARM: dts: sun5i-a10s-auxtek-t004: " Hans de Goede
2016-06-29 14:42 ` [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property Jonas Gorski
2016-06-29 15:16 ` Hans de Goede
2016-06-29 17:00 ` Kalle Valo
2016-06-29 18:01 ` [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm, nvram_file_name " Hans de Goede
2016-06-29 18:51 ` Arend Van Spriel
2016-06-29 18:57 ` Arend Van Spriel
2016-06-30 8:50 ` Kalle Valo
2016-06-29 19:33 ` Arnd Bergmann
2016-06-29 19:54 ` Priit Laes [this message]
2016-06-29 20:07 ` Arnd Bergmann
2016-06-30 9:02 ` Kalle Valo
2016-06-30 9:50 ` Hans de Goede
2016-06-30 9:58 ` Kalle Valo
2016-06-30 10:04 ` Hans de Goede
2016-06-30 10:18 ` Jonas Gorski
2016-06-30 10:25 ` Hans de Goede
2016-06-30 11:31 ` Arnd Bergmann
2016-06-30 19:23 ` Arend Van Spriel
2016-07-01 8:51 ` Arnd Bergmann
2016-07-01 8:58 ` Jonas Gorski
2016-07-02 6:59 ` Kalle Valo
2016-07-02 18:20 ` Arend Van Spriel
2016-07-02 21:30 ` Arnd Bergmann
2016-07-04 8:41 ` Arend Van Spriel
2016-07-04 8:55 ` Arnd Bergmann
2016-07-04 9:08 ` Arend Van Spriel
2016-07-04 14:54 ` Arnd Bergmann
2016-07-04 18:36 ` Arend van Spriel
2016-07-05 13:43 ` Arnd Bergmann
2016-07-06 8:08 ` Arend Van Spriel
2016-07-06 13:42 ` Arnd Bergmann
2016-07-06 19:19 ` Arend Van Spriel
2016-07-07 8:46 ` Arnd Bergmann
2016-07-07 9:16 ` Arend Van Spriel
2016-07-07 9:24 ` Arnd Bergmann
2016-07-17 21:45 ` Rob Herring
2016-07-18 7:51 ` Arend Van Spriel
2016-06-30 8:46 ` Kalle Valo
2016-06-30 9:49 ` Hans de Goede
2016-06-30 9:53 ` Hans de Goede
2016-07-01 2:08 ` [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name " Rob Herring
2016-07-01 8:17 ` Arend Van Spriel
2016-07-01 9:20 ` Arnd Bergmann
2016-07-04 16:12 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467230078.2598.2.camel@plaes.org \
--to=plaes@plaes$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox