From: joe@perches•com (Joe Perches)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 02 Aug 2016 10:52:18 -0700 [thread overview]
Message-ID: <1470160338.3998.193.camel@perches.com> (raw)
In-Reply-To: <20160802174253.GA4628@amd>
On Tue, 2016-08-02 at 19:42 +0200, Pavel Machek wrote:
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
> >
> > -core_param(no_bL_switcher, no_bL_switcher, bool, 0644);
> > +core_param(no_bL_switcher, no_bL_switcher, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
> Everyone knows what 0644 is, but noone can read S_IRUSR | S_IWUSR |
> S_IRCRP | S_IROTH (*). Please don't do this.
Perhaps this conversion is best done in reverse with
most all of the S_[A-Z]{5,5} uses converted to octal.
next prev parent reply other threads:[~2016-08-02 17:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 10:33 [PATCH 0001/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 11:29 ` Russell King - ARM Linux
2016-08-02 13:15 ` One Thousand Gnomes
2016-08-02 15:08 ` Masami Hiramatsu
2016-08-02 17:42 ` Pavel Machek
2016-08-02 17:52 ` Joe Perches [this message]
2016-08-02 17:54 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470160338.3998.193.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox