From: tpiepho@impinj•com (Trent Piepho)
To: linux-arm-kernel@lists•infradead.org
Subject: [2/2] spi: imx: fix use of native chip-selects with devicetree
Date: Thu, 12 Oct 2017 20:41:07 +0000 [thread overview]
Message-ID: <1507840866.3880.4.camel@impinj.com> (raw)
In-Reply-To: <209bb901-875e-8007-06f8-3ae9698a0e41@linux-m68k.org>
On Thu, 2017-10-12 at 16:26 +1000, Greg Ungerer wrote:
> On 11/10/17 06:38, Trent Piepho wrote:
> >
> > arch/arm/mach-imx/mach-mx31moboard.c-static int moboard_spi1_cs[] = {
> > arch/arm/mach-imx/mach-mx31moboard.c: MXC_SPI_CS(0),
> > arch/arm/mach-imx/mach-mx31moboard.c: MXC_SPI_CS(2),
> > arch/arm/mach-imx/mach-mx31moboard.c-};
> >
> > The spi device configured to use chip select 1 will no longer use
> > native chip select line 2.
> >
> > Looking at all in-tree users of spi imx platform data, it appears that
> > this board is the only one in which the cs selected does not match the
> > array index. Though there are still several which still use
> > MSC_SPI_CS() even though it doesn't really work anymore.
>
> Commit 901f26bce64a ("ARM: imx: set correct chip_select in platform setup")
> fixes this issue. It specifically makes sure that the board setup chip
> select is set correctly (so that spi-imx can then use it). It also pads
> out the chipselect arrays so that the chip select and indexes match.
>
> Is this not working for you?
It looks like that patch missed one spi bus in mx31moboard.c, quoted
above.
I have a patch series that should fix that and also the documentation.
Need to test it a bit more.
next prev parent reply other threads:[~2017-10-12 20:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 5:03 [PATCH 0/2] spi: imx: native chip selects and devicetree Greg Ungerer
2017-03-17 5:03 ` [PATCH 1/2] spi: imx: set correct chip_select in platform setup Greg Ungerer
2017-03-20 7:38 ` Shawn Guo
2017-03-20 11:52 ` Greg Ungerer
2017-03-17 5:03 ` [PATCH 2/2] spi: imx: fix use of native chip-selects with devicetree Greg Ungerer
2017-03-20 7:39 ` Shawn Guo
2017-03-20 13:22 ` Vladimir Zapolskiy
2017-03-21 2:05 ` Greg Ungerer
2017-03-21 8:05 ` Uwe Kleine-König
2017-03-21 11:53 ` Greg Ungerer
2017-03-21 12:11 ` Uwe Kleine-König
2017-03-21 13:22 ` Greg Ungerer
2017-03-21 19:23 ` Uwe Kleine-König
2017-03-21 20:15 ` Geert Uytterhoeven
2017-03-22 0:50 ` Greg Ungerer
2017-03-22 7:09 ` Geert Uytterhoeven
2017-09-04 12:47 ` Applied "spi: imx: fix use of native chip-selects with devicetree" to the spi tree Mark Brown
2017-10-10 20:38 ` [2/2] spi: imx: fix use of native chip-selects with devicetree Trent Piepho
2017-10-12 6:26 ` Greg Ungerer
2017-10-12 20:41 ` Trent Piepho [this message]
2017-03-20 7:35 ` [PATCH 0/2] spi: imx: native chip selects and devicetree Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507840866.3880.4.camel@impinj.com \
--to=tpiepho@impinj$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox