From: rick.chang@mediatek•com (Rick Chang)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init()
Date: Fri, 23 Mar 2018 19:07:24 -0700 [thread overview]
Message-ID: <1521857244.3372.12.camel@mediatek.com> (raw)
In-Reply-To: <f9295ecafa4c845ef5d9414fca47b2dc0fc6640d.1521776018.git.ryder.lee@mediatek.com>
On Fri, 2018-03-23 at 11:44 +0800, Ryder Lee wrote:
> The error return value should be fixed as it may return EPROBE_DEFER.
>
> Cc: Rick Chang <rick.chang@mediatek•com>
> Cc: Bin Liu <bin.liu@mediatek•com>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek•com>
> ---
> ?drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++--
> ?1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> index 226f908..af17aaa 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -1081,11 +1081,11 @@ static int mtk_jpeg_clk_init(struct
> mtk_jpeg_dev *jpeg)
> ?
> ? jpeg->clk_jdec = devm_clk_get(jpeg->dev, "jpgdec");
> ? if (IS_ERR(jpeg->clk_jdec))
> - return -EINVAL;
> + return PTR_ERR(jpeg->clk_jdec);
> ?
> ? jpeg->clk_jdec_smi = devm_clk_get(jpeg->dev, "jpgdec-smi");
> ? if (IS_ERR(jpeg->clk_jdec_smi))
> - return -EINVAL;
> + return PTR_ERR(jpeg->clk_jdec_smi);
> ?
> ? return 0;
> ?}
Acked-by: Rick Chang <rick.chang@mediatek•com>
prev parent reply other threads:[~2018-03-24 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 3:44 [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init() Ryder Lee
2018-03-23 17:19 ` Matthias Brugger
2018-03-24 2:07 ` Rick Chang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521857244.3372.12.camel@mediatek.com \
--to=rick.chang@mediatek$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox