From: jeffrey.t.kirsher@intel•com (Jeff Kirsher)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v8 0/7] netdev: intel: Eliminate duplicate barriers on weakly-ordered archs
Date: Tue, 03 Apr 2018 11:26:07 -0700 [thread overview]
Message-ID: <1522779967.4236.22.camel@intel.com> (raw)
In-Reply-To: <92f46034-f041-05e4-56b7-01ae4cb04efc@codeaurora.org>
On Tue, 2018-04-03 at 13:50 -0400, Sinan Kaya wrote:
> > > What do you think about this version? Did I miss any SMP
> > > barriers?
> >
> > I would say we should probably just drop the whole set and start
> > over.
> > If we don't need the wmb() we are going to need to go through and
> > clean up all of these paths and consider the barriers when updating
> > the layout of the code.
> >
> > For example I have been thinking about it and in the case of x86 we
> > are probably better off not bothering with the wmb() and
> > writel_relaxed() and instead switch over to the smp_wmb() and
> > writel()
> > since in the case of a strongly ordered system like x86 or sparc
> > this
> > ends up translating out to a couple of compile barriers.
> >
> > I will also need time to reevaluate the Rx paths since dropping the
> > wmb() may have other effects which I need to verify.
>
> Sounds good, I'll let you work on it.
>
> @Jeff Kirsher: can you drop this version from your development branch
> until
> Alex posts the next version?
Already on it, I will work with Alex on any possible future versions of
these patches.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180403/df3259a9/attachment.sig>
prev parent reply other threads:[~2018-04-03 18:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 19:06 [PATCH v8 0/7] netdev: intel: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-04-02 19:06 ` [PATCH v8 1/7] i40e/i40evf: " Sinan Kaya
2018-04-02 19:06 ` [PATCH v8 2/7] ixgbe: eliminate " Sinan Kaya
2018-04-02 19:06 ` [PATCH v8 3/7] igbvf: " Sinan Kaya
2018-04-02 19:06 ` [PATCH v8 4/7] igb: " Sinan Kaya
2018-04-02 19:06 ` [PATCH v8 5/7] fm10k: Eliminate " Sinan Kaya
2018-04-02 19:06 ` [PATCH v8 6/7] ixgbevf: keep writel() closer to wmb() Sinan Kaya
2018-04-02 19:06 ` [PATCH v8 7/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-04-03 2:59 ` [PATCH v8 0/7] netdev: intel: Eliminate " Sinan Kaya
2018-04-03 17:47 ` Alexander Duyck
2018-04-03 17:50 ` Sinan Kaya
2018-04-03 18:26 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522779967.4236.22.camel@intel.com \
--to=jeffrey.t.kirsher@intel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox