From: Jitao Shi <jitao.shi@mediatek•com>
To: CK Hu <ck.hu@mediatek•com>
Cc: Mark Rutland <mark.rutland@arm•com>,
devicetree@vger•kernel.org, David Airlie <airlied@linux•ie>,
stonea168@163•com, dri-devel@lists•freedesktop.org,
yingjoe.chen@mediatek•com, Ajay Kumar <ajaykumar.rs@samsung•com>,
Vincent Palatin <vpalatin@chromium•org>,
cawa.cheng@mediatek•com, bibby.hsieh@mediatek•com,
Russell King <rmk+kernel@arm•linux.org.uk>,
Thierry Reding <treding@nvidia•com>,
linux-pwm@vger•kernel.org, Sascha Hauer <kernel@pengutronix•de>,
Pawel Moll <pawel.moll@arm•com>,
Ian Campbell <ijc+devicetree@hellion•org.uk>,
Inki Dae <inki.dae@samsung•com>, Rob Herring <robh+dt@kernel•org>,
linux-mediatek@lists•infradead.org,
Andy Yan <andy.yan@rock-chips•com>,
Matthias Brugger <matthias.bgg@gmail•com>,
eddie.huang@mediatek•com, linux-arm-kernel@lists•infradead.org,
Rahul Sharma <rahul.sharma@samsung•com>,
srv_heupstream@mediatek•com, linux-kernel@vger•kernel.org,
Philipp Zabel <p.zabel@pengutronix•de>,
Kumar Gala <galak@codeaurora•org>,
Sean Paul <seanpaul@chromium•org>
Subject: Re: [v3 3/3] drm/mediatek: add mt8183 dpi support
Date: Sun, 19 May 2019 17:37:21 +0800 [thread overview]
Message-ID: <1558258641.367.6.camel@mszsdaap41> (raw)
In-Reply-To: <1557214887.3498.7.camel@mtksdaap41>
On Tue, 2019-05-07 at 15:41 +0800, CK Hu wrote:
> Hi, Jitao:
>
> On Tue, 2019-04-16 at 13:52 +0800, Jitao Shi wrote:
>
> I need the commit message. Even though the code is easy to understand,
> words for this patch is still necessary.
>
> Regards,
> CK
>
I'll fine tune the commit message next version.
Best Regards
Jitao
> > Signed-off-by: Jitao Shi <jitao.shi@mediatek•com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_dpi.c | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 66405159141a..fbb087218775 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -681,6 +681,16 @@ static unsigned int mt2701_calculate_factor(int clock)
> > return 2;
> > }
> >
> > +static unsigned int mt8183_calculate_factor(int clock)
> > +{
> > + if (clock <= 27000)
> > + return 8;
> > + else if (clock <= 167000)
> > + return 4;
> > + else
> > + return 2;
> > +}
> > +
> > static const struct mtk_dpi_conf mt8173_conf = {
> > .cal_factor = mt8173_calculate_factor,
> > .reg_h_fre_con = 0xe0,
> > @@ -692,6 +702,12 @@ static const struct mtk_dpi_conf mt2701_conf = {
> > .edge_sel_en = true,
> > };
> >
> > +static const struct mtk_dpi_conf mt8183_conf = {
> > + .cal_factor = mt8183_calculate_factor,
> > + .reg_h_fre_con = 0xe0,
> > + .dual_edge = true,
> > +};
> > +
> > static int mtk_dpi_probe(struct platform_device *pdev)
> > {
> > struct device *dev = &pdev->dev;
> > @@ -787,6 +803,9 @@ static const struct of_device_id mtk_dpi_of_ids[] = {
> > { .compatible = "mediatek,mt8173-dpi",
> > .data = &mt8173_conf,
> > },
> > + { .compatible = "mediatek,mt8183-dpi",
> > + .data = &mt8183_conf,
> > + },
> > { },
> > };
> >
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-05-19 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 5:52 [v3 0/3] support dpi for mt8183 Jitao Shi
2019-04-16 5:52 ` [v3 1/3] dt-bindings: display: mediatek: update dpi supported chips Jitao Shi
2019-04-26 22:49 ` Rob Herring
2019-04-16 5:52 ` [v3 2/3] drm/mediatek: dpi dual edge support Jitao Shi
2019-05-07 7:35 ` CK Hu
2019-04-16 5:52 ` [v3 3/3] drm/mediatek: add mt8183 dpi support Jitao Shi
2019-05-07 7:41 ` CK Hu
2019-05-19 9:37 ` Jitao Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558258641.367.6.camel@mszsdaap41 \
--to=jitao.shi@mediatek$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=ajaykumar.rs@samsung$(echo .)com \
--cc=andy.yan@rock-chips$(echo .)com \
--cc=bibby.hsieh@mediatek$(echo .)com \
--cc=cawa.cheng@mediatek$(echo .)com \
--cc=ck.hu@mediatek$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=eddie.huang@mediatek$(echo .)com \
--cc=galak@codeaurora$(echo .)org \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=inki.dae@samsung$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-pwm@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=pawel.moll@arm$(echo .)com \
--cc=rahul.sharma@samsung$(echo .)com \
--cc=rmk+kernel@arm$(echo .)linux.org.uk \
--cc=robh+dt@kernel$(echo .)org \
--cc=seanpaul@chromium$(echo .)org \
--cc=srv_heupstream@mediatek$(echo .)com \
--cc=stonea168@163$(echo .)com \
--cc=treding@nvidia$(echo .)com \
--cc=vpalatin@chromium$(echo .)org \
--cc=yingjoe.chen@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox