From: Hoan Tran OS <hoan@os•amperecomputing.com>
To: Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will.deacon@arm•com>,
Andrew Morton <akpm@linux-foundation•org>,
Michal Hocko <mhocko@suse•com>, Vlastimil Babka <vbabka@suse•cz>,
Oscar Salvador <osalvador@suse•de>,
Pavel Tatashin <pavel.tatashin@microsoft•com>,
Mike Rapoport <rppt@linux•ibm.com>,
Alexander Duyck <alexander.h.duyck@linux•intel.com>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Michael Ellerman <mpe@ellerman•id.au>,
Thomas Gleixner <tglx@linutronix•de>,
Ingo Molnar <mingo@redhat•com>, Borislav Petkov <bp@alien8•de>,
"H . Peter Anvin" <hpa@zytor•com>,
"David S . Miller" <davem@davemloft•net>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
Vasily Gorbik <gor@linux•ibm.com>,
Christian Borntraeger <borntraeger@de•ibm.com>
Cc: "linux-s390@vger•kernel.org" <linux-s390@vger•kernel.org>,
"x86@kernel•org" <x86@kernel•org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack•org>,
Hoan Tran OS <hoan@os•amperecomputing.com>,
"sparclinux@vger•kernel.org" <sparclinux@vger•kernel.org>,
Open Source Submission <patches@amperecomputing•com>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>
Subject: [PATCH v2 1/5] mm: Enable CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA
Date: Thu, 11 Jul 2019 23:25:46 +0000 [thread overview]
Message-ID: <1562887528-5896-2-git-send-email-Hoan@os.amperecomputing.com> (raw)
In-Reply-To: <1562887528-5896-1-git-send-email-Hoan@os.amperecomputing.com>
In NUMA layout which nodes have memory ranges that span across other nodes,
the mm driver can detect the memory node id incorrectly.
For example, with layout below
Node 0 address: 0000 xxxx 0000 xxxx
Node 1 address: xxxx 1111 xxxx 1111
Note:
- Memory from low to high
- 0/1: Node id
- x: Invalid memory of a node
When mm probes the memory map, without CONFIG_NODES_SPAN_OTHER_NODES
config, mm only checks the memory validity but not the node id.
Because of that, Node 1 also detects the memory from node 0 as below
when it scans from the start address to the end address of node 1.
Node 0 address: 0000 xxxx xxxx xxxx
Node 1 address: xxxx 1111 1111 1111
This layout could occur on any architecture. This patch enables
CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA to fix this issue.
Signed-off-by: Hoan Tran <Hoan@os•amperecomputing.com>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index d66bc8a..6335505 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1413,7 +1413,7 @@ int __meminit early_pfn_to_nid(unsigned long pfn)
}
#endif
-#ifdef CONFIG_NODES_SPAN_OTHER_NODES
+#ifdef CONFIG_NUMA
/* Only safe to use early in boot when initialisation is single-threaded */
static inline bool __meminit early_pfn_in_nid(unsigned long pfn, int node)
{
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-11 23:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 23:25 [PATCH v2 0/5] mm: Enable CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA Hoan Tran OS
2019-07-11 23:25 ` Hoan Tran OS [this message]
2019-07-11 23:25 ` [PATCH v2 2/5] powerpc: Kconfig: Remove CONFIG_NODES_SPAN_OTHER_NODES Hoan Tran OS
2019-07-11 23:25 ` [PATCH v2 3/5] x86: " Hoan Tran OS
2019-07-15 18:43 ` Thomas Gleixner
2019-08-06 16:47 ` Hoan Tran OS
2019-07-11 23:25 ` [PATCH v2 4/5] sparc: " Hoan Tran OS
2019-07-11 23:25 ` [PATCH v2 5/5] s390: " Hoan Tran OS
2019-07-12 2:45 ` [PATCH v2 0/5] mm: Enable CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA Matthew Wilcox
2019-07-12 7:02 ` Michal Hocko
2019-07-12 10:56 ` Hoan Tran OS
2019-07-12 12:12 ` Michal Hocko
2019-07-12 14:37 ` Will Deacon
2019-07-12 15:00 ` Michal Hocko
2019-07-15 17:55 ` Hoan Tran OS
2019-07-30 8:14 ` Michal Hocko
2019-07-30 17:31 ` Hoan Tran OS
2019-07-31 6:24 ` Mike Rapoport
2019-07-31 8:03 ` Michal Hocko
2019-07-31 11:14 ` Mike Rapoport
2019-07-31 11:40 ` Michal Hocko
2019-07-31 12:26 ` Mike Rapoport
2019-07-31 13:00 ` microblaze HAVE_MEMBLOCK_NODE_MAP dependency (was Re: [PATCH v2 0/5] mm: Enable CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA) Michal Hocko
2019-07-31 14:21 ` Mike Rapoport
2019-07-31 14:41 ` Michal Hocko
2019-07-31 17:15 ` Mike Rapoport
2019-07-31 17:45 ` Randy Dunlap
2019-09-02 13:51 ` Michal Simek
2019-09-02 15:18 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562887528-5896-2-git-send-email-Hoan@os.amperecomputing.com \
--to=hoan@os$(echo .)amperecomputing.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander.h.duyck@linux$(echo .)intel.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gor@linux$(echo .)ibm.com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mhocko@suse$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=osalvador@suse$(echo .)de \
--cc=patches@amperecomputing$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=pavel.tatashin@microsoft$(echo .)com \
--cc=rppt@linux$(echo .)ibm.com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=vbabka@suse$(echo .)cz \
--cc=will.deacon@arm$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox