From: Anson Huang <Anson.Huang@nxp•com>
To: thierry.reding@gmail•com, shawnguo@kernel•org,
s.hauer@pengutronix•de, kernel@pengutronix•de,
festevam@gmail•com, linux-pwm@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org
Cc: Linux-imx@nxp•com
Subject: [PATCH] pwm: pwm-imx27: Use 'dev' instead of dereferencing it repeatedly
Date: Tue, 24 Sep 2019 16:59:53 +0800 [thread overview]
Message-ID: <1569315593-769-1-git-send-email-Anson.Huang@nxp.com> (raw)
Add helper variable dev = &pdev->dev to simply the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp•com>
---
drivers/pwm/pwm-imx27.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
index 434a351..3afee29 100644
--- a/drivers/pwm/pwm-imx27.c
+++ b/drivers/pwm/pwm-imx27.c
@@ -290,27 +290,28 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids);
static int pwm_imx27_probe(struct platform_device *pdev)
{
+ struct device *dev = &pdev->dev;
struct pwm_imx27_chip *imx;
- imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
+ imx = devm_kzalloc(dev, sizeof(*imx), GFP_KERNEL);
if (imx == NULL)
return -ENOMEM;
platform_set_drvdata(pdev, imx);
- imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg");
+ imx->clk_ipg = devm_clk_get(dev, "ipg");
if (IS_ERR(imx->clk_ipg)) {
- dev_err(&pdev->dev, "getting ipg clock failed with %ld\n",
+ dev_err(dev, "getting ipg clock failed with %ld\n",
PTR_ERR(imx->clk_ipg));
return PTR_ERR(imx->clk_ipg);
}
- imx->clk_per = devm_clk_get(&pdev->dev, "per");
+ imx->clk_per = devm_clk_get(dev, "per");
if (IS_ERR(imx->clk_per)) {
int ret = PTR_ERR(imx->clk_per);
if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
+ dev_err(dev,
"failed to get peripheral clock: %d\n",
ret);
@@ -318,7 +319,7 @@ static int pwm_imx27_probe(struct platform_device *pdev)
}
imx->chip.ops = &pwm_imx27_ops;
- imx->chip.dev = &pdev->dev;
+ imx->chip.dev = dev;
imx->chip.base = -1;
imx->chip.npwm = 1;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-09-24 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 8:59 Anson Huang [this message]
2019-09-24 9:46 ` [PATCH] pwm: pwm-imx27: Use 'dev' instead of dereferencing it repeatedly David Laight
2019-09-24 10:03 ` Anson Huang
2019-09-24 10:43 ` David Laight
2019-09-25 2:36 ` Anson Huang
2019-09-24 10:52 ` Thierry Reding
2019-10-02 7:33 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1569315593-769-1-git-send-email-Anson.Huang@nxp.com \
--to=anson.huang@nxp$(echo .)com \
--cc=Linux-imx@nxp$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pwm@vger$(echo .)kernel.org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=thierry.reding@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox