From: Can Guo <cang@codeaurora•org>
To: asutoshd@codeaurora•org, nguyenb@codeaurora•org,
hongwus@codeaurora•org, rnayak@codeaurora•org,
linux-scsi@vger•kernel.org, kernel-team@android•com,
saravanak@google•com, salyzyn@google•com, cang@codeaurora•org
Cc: Bart Van Assche <bvanassche@acm•org>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
Venkat Gopalakrishnan <venkatg@codeaurora•org>,
"James E.J. Bottomley" <jejb@linux•ibm.com>,
open list <linux-kernel@vger•kernel.org>,
Avri Altman <avri.altman@wdc•com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists•infradead.org>,
Alim Akhtar <alim.akhtar@samsung•com>,
Matthias Brugger <matthias.bgg@gmail•com>,
Tomas Winkler <tomas.winkler@intel•com>,
Stanley Chu <stanley.chu@mediatek•com>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists•infradead.org>,
Bean Huo <beanhuo@micron•com>
Subject: [PATCH v2 1/1] scsi: ufs: full reinit upon resume if link was off
Date: Mon, 13 Apr 2020 23:14:48 -0700 [thread overview]
Message-ID: <1586844892-22720-1-git-send-email-cang@codeaurora.org> (raw)
From: Asutosh Das <asutoshd@codeaurora•org>
During suspend, if the link is put to off, it would require
a full initialization during resume. This patch resets and
restores both the host and the card during initialization,
otherwise, host only reset and restore may fail occasionally.
Signed-off-by: Asutosh Das <asutoshd@codeaurora•org>
Signed-off-by: Can Guo <cang@codeaurora•org>
Reviewed-by: Bean Huo <beanhuo@micron•com>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung•com>
Acked-by: Stanley Chu <stanley.chu@mediatek•com>
Change since v1:
- Incorporated Alim's comments.
---
drivers/scsi/ufs/ufshcd.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 64e42ef..90313c8 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -8048,9 +8048,13 @@ static int ufshcd_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)
else
goto vendor_suspend;
} else if (ufshcd_is_link_off(hba)) {
- ret = ufshcd_host_reset_and_restore(hba);
/*
- * ufshcd_host_reset_and_restore() should have already
+ * A full initialization of the host and the device is
+ * required since the link was put to off during suspend.
+ */
+ ret = ufshcd_reset_and_restore(hba);
+ /*
+ * ufshcd_reset_and_restore() should have already
* set the link state as active
*/
if (ret || !ufshcd_is_link_active(hba))
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-04-14 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 6:14 Can Guo [this message]
2020-04-17 21:26 ` [PATCH v2 1/1] scsi: ufs: full reinit upon resume if link was off Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1586844892-22720-1-git-send-email-cang@codeaurora.org \
--to=cang@codeaurora$(echo .)org \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=asutoshd@codeaurora$(echo .)org \
--cc=avri.altman@wdc$(echo .)com \
--cc=beanhuo@micron$(echo .)com \
--cc=bvanassche@acm$(echo .)org \
--cc=hongwus@codeaurora$(echo .)org \
--cc=jejb@linux$(echo .)ibm.com \
--cc=kernel-team@android$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=martin.petersen@oracle$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=nguyenb@codeaurora$(echo .)org \
--cc=rnayak@codeaurora$(echo .)org \
--cc=salyzyn@google$(echo .)com \
--cc=saravanak@google$(echo .)com \
--cc=stanley.chu@mediatek$(echo .)com \
--cc=tomas.winkler@intel$(echo .)com \
--cc=venkatg@codeaurora$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox