From: Can Guo <cang@codeaurora•org>
To: asutoshd@codeaurora•org, nguyenb@codeaurora•org,
hongwus@codeaurora•org, rnayak@codeaurora•org,
linux-scsi@vger•kernel.org, kernel-team@android•com,
saravanak@google•com, salyzyn@google•com, cang@codeaurora•org
Cc: Bart Van Assche <bvanassche@acm•org>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
"James E.J. Bottomley" <jejb@linux•ibm.com>,
open list <linux-kernel@vger•kernel.org>,
Avri Altman <avri.altman@wdc•com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists•infradead.org>,
Alim Akhtar <alim.akhtar@samsung•com>,
Matthias Brugger <matthias.bgg@gmail•com>,
Stanley Chu <stanley.chu@mediatek•com>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists•infradead.org>,
Bean Huo <beanhuo@micron•com>
Subject: [PATCH v6 3/3] scsi: ufs: Revert "Make sure clk scaling happens only when HBA is runtime ACTIVE"
Date: Sat, 19 Dec 2020 21:42:47 -0800 [thread overview]
Message-ID: <1608442968-38560-4-git-send-email-cang@codeaurora.org> (raw)
In-Reply-To: <1608442968-38560-1-git-send-email-cang@codeaurora.org>
Commit 73cc291c27024 ("Make sure clk scaling happens only when HBA is
runtime ACTIVE") is no longer needed since commit f7a42540928a8 ("scsi:
ufs: Protect some contexts from unexpected clock scaling") is a more
mature fix to protect UFS LLD stability from clock scaling invoked through
sysfs nodes by users.
Reviewed-by: Stanley Chu <stanley.chu@mediatek•com>
Signed-off-by: Can Guo <cang@codeaurora•org>
---
drivers/scsi/ufs/ufshcd.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 2dee21e..7229a1b 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -1300,15 +1300,8 @@ static int ufshcd_devfreq_target(struct device *dev,
}
spin_unlock_irqrestore(hba->host->host_lock, irq_flags);
- pm_runtime_get_noresume(hba->dev);
- if (!pm_runtime_active(hba->dev)) {
- pm_runtime_put_noidle(hba->dev);
- ret = -EAGAIN;
- goto out;
- }
start = ktime_get();
ret = ufshcd_devfreq_scale(hba, scale_up);
- pm_runtime_put(hba->dev);
trace_ufshcd_profile_clk_scaling(dev_name(hba->dev),
(scale_up ? "up" : "down"),
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-12-20 5:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1608442968-38560-1-git-send-email-cang@codeaurora.org>
2020-12-20 5:42 ` [PATCH v6 1/3] scsi: ufs: Protect some contexts from unexpected clock scaling Can Guo
2020-12-20 5:42 ` [PATCH v6 2/3] scsi: ufs: Clean up ufshcd_exit_clk_scaling/gating() Can Guo
2020-12-20 5:42 ` Can Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1608442968-38560-4-git-send-email-cang@codeaurora.org \
--to=cang@codeaurora$(echo .)org \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=asutoshd@codeaurora$(echo .)org \
--cc=avri.altman@wdc$(echo .)com \
--cc=beanhuo@micron$(echo .)com \
--cc=bvanassche@acm$(echo .)org \
--cc=hongwus@codeaurora$(echo .)org \
--cc=jejb@linux$(echo .)ibm.com \
--cc=kernel-team@android$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=martin.petersen@oracle$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=nguyenb@codeaurora$(echo .)org \
--cc=rnayak@codeaurora$(echo .)org \
--cc=salyzyn@google$(echo .)com \
--cc=saravanak@google$(echo .)com \
--cc=stanley.chu@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox