From: laurent.pinchart@ideasonboard•com (Laurent Pinchart)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH/RFC v3 02/22] soc: renesas: Add R-Car RST driver
Date: Fri, 10 Jun 2016 16:08:41 +0300 [thread overview]
Message-ID: <1642491.VRMI5sK8yv@avalon> (raw)
In-Reply-To: <CAMuHMdUX=iAe=51+8JyaKxMBOUA_jJXGK0BTKxRuTXtug_R1Tw@mail.gmail.com>
On Friday 10 Jun 2016 09:58:28 Geert Uytterhoeven wrote:
> Hi Dirk,
>
> On Thu, Jun 2, 2016 at 7:42 AM, Dirk Behme <dirk.behme@de•bosch.com> wrote:
> >> +int __init rcar_rst_read_mode_pins(u32 *mode)
> >
> > Just a style issue: Is the string 'pins' in the function name still
> > relevant? I.e. what's about just 'rcar_rst_read_mode()'?
>
> I feel "mode" is a too generic word for a public API.
> It's used a several contexts inside the RST module (secure mode, 64-bit
> addressing mode, free-running mode, step-up mode).
<bikeshedding>
If it's "pins" that bothers Dirk, how about rcar_rst_read_boot_mode() ? Or
maybe rcar_rst_boot_mode(), given that the function caches the value, it
doesn't read it every time.
</bikeshedding>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-06-10 13:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1464808880-343-1-git-send-email-geert+renesas@glider.be>
[not found] ` <1464808880-343-3-git-send-email-geert+renesas@glider.be>
2016-06-02 5:42 ` [PATCH/RFC v3 02/22] soc: renesas: Add R-Car RST driver Dirk Behme
2016-06-10 7:58 ` Geert Uytterhoeven
2016-06-10 8:38 ` Dirk Behme
2016-06-10 13:08 ` Laurent Pinchart [this message]
2016-06-02 21:58 ` Laurent Pinchart
2016-06-10 7:54 ` Geert Uytterhoeven
[not found] ` <1464808880-343-21-git-send-email-geert+renesas@glider.be>
2016-06-02 5:54 ` [PATCH/RFC v3 20/22] clk: renesas: r8a7778: Remove obsolete r8a7778_clocks_init() Dirk Behme
2016-06-02 7:13 ` Geert Uytterhoeven
2016-06-02 5:57 ` [PATCH/RFC v3 00/22] soc: renesas: Add R-Car RST driver for obtaining mode pin state Dirk Behme
[not found] ` <1464808880-343-2-git-send-email-geert+renesas@glider.be>
2016-06-02 5:40 ` [PATCH/RFC v3 01/22] reset: Add renesas,rst DT bindings Dirk Behme
2016-06-02 21:47 ` Laurent Pinchart
2016-06-10 7:52 ` Geert Uytterhoeven
[not found] ` <1464808880-343-15-git-send-email-geert+renesas@glider.be>
2016-06-02 22:01 ` [PATCH/RFC v3 14/22] clk: renesas: r8a7795: Obtain mode pin values from R-Car RST driver Laurent Pinchart
[not found] ` <1464808880-343-16-git-send-email-geert+renesas@glider.be>
2016-06-02 22:02 ` [PATCH/RFC v3 15/22] clk: renesas: r8a7796: " Laurent Pinchart
[not found] ` <1464808880-343-17-git-send-email-geert+renesas@glider.be>
2016-06-02 22:02 ` [PATCH/RFC v3 16/22] clk: renesas: rcar-gen3-cpg: Remove obsolete rcar_gen3_read_mode_pins() Laurent Pinchart
2016-06-30 20:14 ` [PATCH/RFC v3 00/22] soc: renesas: Add R-Car RST driver for obtaining mode pin state Stephen Boyd
2016-09-01 11:46 ` Geert Uytterhoeven
2016-09-12 22:16 ` Stephen Boyd
2016-09-13 6:48 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1642491.VRMI5sK8yv@avalon \
--to=laurent.pinchart@ideasonboard$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox