From: Heiko Stuebner <heiko@sntech•de>
To: Souptick Joarder <jrdr.linux@gmail•com>
Cc: mhocko@suse•com, peterz@infradead•org,
dri-devel@lists•freedesktop.org, linux-kernel@vger•kernel.org,
linux-mm@kvack•org, linux1394-devel@lists•sourceforge.net,
m.szyprowski@samsung•com, sfr@canb•auug.org.au,
oleksandr_andrushchenko@epam•com, joro@8bytes•org,
linux@armlinux•org.uk, willy@infradead•org, airlied@linux•ie,
linux-arm-kernel@lists•infradead.org,
linux-rockchip@lists•infradead.org, treding@nvidia•com,
linux-media@vger•kernel.org, keescook@chromium•org,
pawel@osciak•com, riel@surriel•com,
iommu@lists•linux-foundation.org, rppt@linux•vnet.ibm.com,
boris.ostrovsky@oracle•com, mchehab@kernel•org,
iamjoonsoo.kim@lge•com, vbabka@suse•cz, jgross@suse•com,
hjc@rock-chips•com, xen-devel@lists•xen.org,
kyungmin.park@samsung•com, stefanr@s5r6•in-berlin.de,
akpm@linux-foundation•org, robin.murphy@arm•com,
kirill.shutemov@linux•intel.com
Subject: Re: [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API
Date: Thu, 31 Jan 2019 13:06:49 +0100 [thread overview]
Message-ID: <1701923.z6LKAITQJA@phil> (raw)
In-Reply-To: <20190131030812.GA2174@jordon-HP-15-Notebook-PC>
Am Donnerstag, 31. Januar 2019, 04:08:12 CET schrieb Souptick Joarder:
> Previouly drivers have their own way of mapping range of
> kernel pages/memory into user vma and this was done by
> invoking vm_insert_page() within a loop.
>
> As this pattern is common across different drivers, it can
> be generalized by creating new functions and use it across
> the drivers.
>
> vm_insert_range() is the API which could be used to mapped
> kernel memory/pages in drivers which has considered vm_pgoff
>
> vm_insert_range_buggy() is the API which could be used to map
> range of kernel memory/pages in drivers which has not considered
> vm_pgoff. vm_pgoff is passed default as 0 for those drivers.
>
> We _could_ then at a later "fix" these drivers which are using
> vm_insert_range_buggy() to behave according to the normal vm_pgoff
> offsetting simply by removing the _buggy suffix on the function
> name and if that causes regressions, it gives us an easy way to revert.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail•com>
> Suggested-by: Russell King <linux@armlinux•org.uk>
> Suggested-by: Matthew Wilcox <willy@infradead•org>
hmm, I'm missing a changelog here between v1 and v2.
Nevertheless I managed to test v1 on Rockchip hardware
and display is still working, including talking to Lima via prime.
So if there aren't any big changes for v2, on Rockchip
Tested-by: Heiko Stuebner <heiko@sntech•de>
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-31 12:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 3:08 [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API Souptick Joarder
2019-01-31 8:38 ` Mike Rapoport
2019-01-31 10:13 ` Souptick Joarder
2019-01-31 11:06 ` Mike Rapoport
2019-02-07 15:49 ` Souptick Joarder
2019-02-07 15:57 ` Mike Rapoport
2019-02-07 16:07 ` Souptick Joarder
2019-02-07 16:04 ` Mike Rapoport
2019-02-07 16:47 ` Matthew Wilcox
2019-02-08 5:22 ` Souptick Joarder
2019-02-11 17:06 ` Souptick Joarder
2019-01-31 12:06 ` Heiko Stuebner [this message]
2019-01-31 12:31 ` Souptick Joarder
2019-01-31 12:34 ` Heiko Stuebner
2019-02-01 12:38 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1701923.z6LKAITQJA@phil \
--to=heiko@sntech$(echo .)de \
--cc=airlied@linux$(echo .)ie \
--cc=akpm@linux-foundation$(echo .)org \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=hjc@rock-chips$(echo .)com \
--cc=iamjoonsoo.kim@lge$(echo .)com \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=jgross@suse$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=jrdr.linux@gmail$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kirill.shutemov@linux$(echo .)intel.com \
--cc=kyungmin.park@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux1394-devel@lists$(echo .)sourceforge.net \
--cc=linux@armlinux$(echo .)org.uk \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=mhocko@suse$(echo .)com \
--cc=oleksandr_andrushchenko@epam$(echo .)com \
--cc=pawel@osciak$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=riel@surriel$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=rppt@linux$(echo .)vnet.ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=stefanr@s5r6$(echo .)in-berlin.de \
--cc=treding@nvidia$(echo .)com \
--cc=vbabka@suse$(echo .)cz \
--cc=willy@infradead$(echo .)org \
--cc=xen-devel@lists$(echo .)xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox