From: broonie@opensource•wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/7] S3C64XX DMA: S3C2410_DMAF_CIRCULAR disable
Date: Tue, 15 Sep 2009 11:07:51 +0100 [thread overview]
Message-ID: <20090915100751.GC22878@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1253008882-7587-1-git-send-email-jassi.brar@samsung.com>
On Tue, Sep 15, 2009 at 07:01:22PM +0900, Jassi wrote:
> +#if 0
> if (chan->flags & S3C2410_DMAF_CIRCULAR) {
> struct s3c64xx_dma_buff *curr = chan->curr;
> lli->next_lli = curr->lli_dma;
> }
> +#endif
If you're doing something like this you should remove the code rather
than if 0 it out, or at least insert a comment explaining why the code
is sitting around. Though I'm a bit concerned that if something has
actually tried to set up circular DMA it might get upset if that's
ignored (not that I've looked in detail).
next prev parent reply other threads:[~2009-09-15 10:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 10:01 [PATCH 4/7] S3C64XX DMA: S3C2410_DMAF_CIRCULAR disable Jassi
2009-09-15 10:07 ` Mark Brown [this message]
2009-09-15 11:01 ` jassi brar
2009-09-15 11:52 ` Mark Brown
2009-09-15 12:05 ` jassi brar
2009-09-16 0:28 ` Ben Dooks
2009-09-16 2:24 ` jassi brar
2009-09-22 20:14 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915100751.GC22878@rakim.wolfsonmicro.main \
--to=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox